GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vendorcode/siemens/hwilib: Fix current file string usage 

The CAR_GLOBAL accessors likely hid a bug where strncmp/cpy was passed
a pointer to a char array instead of the char array.

Change-Id: I68788e47ef27a959d6e048e9385afcfb663cdebc
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37077
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Arthur Heymans 2019-11-21 08:00:27 +01:00 committed by Patrick Georgi
parent b6c9a5d797
commit 5b0db35e0d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/vendorcode/siemens/hwilib/hwilib.c
View File

@ -476,7 +476,7 @@ enum cb_err hwilib_find_blocks (const char *hwi_filename)
return CB_ERR_ARG; return CB_ERR_ARG;
/* Check if this file is already open. If yes, just leave as there is /* Check if this file is already open. If yes, just leave as there is
nothing left to do here. */ nothing left to do here. */
if (!strncmp((char *)&current_hwi, hwi_filename, HWI_MAX_NAME_LEN)) { if (!strncmp(current_hwi, hwi_filename, HWI_MAX_NAME_LEN)) {
printk(BIOS_SPEW, "HWILIB: File \"%s\" already open.\n", printk(BIOS_SPEW, "HWILIB: File \"%s\" already open.\n",
hwi_filename); hwi_filename);
return CB_SUCCESS; return CB_SUCCESS;
@ -543,7 +543,7 @@ enum cb_err hwilib_find_blocks (const char *hwi_filename)
if (all_blocks[BLK_HIB] || all_blocks[BLK_SIB] || all_blocks[BLK_EIB] || if (all_blocks[BLK_HIB] || all_blocks[BLK_SIB] || all_blocks[BLK_EIB] ||
all_blocks[BLK_XIB]) { all_blocks[BLK_XIB]) {
/* Save currently opened hwi filename. */ /* Save currently opened hwi filename. */
strncpy((char *)&current_hwi, hwi_filename, HWI_MAX_NAME_LEN); strncpy(current_hwi, hwi_filename, HWI_MAX_NAME_LEN);
return CB_SUCCESS; return CB_SUCCESS;
} }
else else