GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CBMEM: Drop cbmem_base_check() 

This function was for logging only, but we have both base and size
already logged elsewhere.

Change-Id: Ie6ac71fc859b8fd42fcf851c316a5f888f828dc2
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/4620
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-by: Aaron Durbin <adurbin@google.com>
This commit is contained in:
Kyösti Mälkki 2014-01-05 08:49:29 +02:00
parent cb28f3f8ed
commit 5b353002a9
4 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/arch/armv7/tables.c
View File

@ -50,10 +50,6 @@ struct lb_memory *write_tables(void)
{ {
unsigned long table_pointer, new_table_pointer; unsigned long table_pointer, new_table_pointer;
#if !CONFIG_DYNAMIC_CBMEM
cbmem_base_check();
#endif
post_code(0x9d); post_code(0x9d);
table_pointer = (unsigned long)cbmem_add(CBMEM_ID_CBTABLE, table_pointer = (unsigned long)cbmem_add(CBMEM_ID_CBTABLE,

4
src/arch/x86/boot/tables.c
View File

@ -50,10 +50,6 @@ struct lb_memory *write_tables(void)
*/ */
unsigned long high_table_pointer; unsigned long high_table_pointer;
#if !CONFIG_DYNAMIC_CBMEM
cbmem_base_check();
#endif
rom_table_start = 0xf0000; rom_table_start = 0xf0000;
rom_table_end = 0xf0000; rom_table_end = 0xf0000;

1
src/include/cbmem.h
View File

@ -134,7 +134,6 @@ u64 cbmem_entry_size(const struct cbmem_entry *entry);
void set_top_of_ram(uint64_t ramtop); void set_top_of_ram(uint64_t ramtop);
void backup_top_of_ram(uint64_t ramtop); void backup_top_of_ram(uint64_t ramtop);
void cbmem_late_set_table(uint64_t base, uint64_t size); void cbmem_late_set_table(uint64_t base, uint64_t size);
int cbmem_base_check(void);
#endif #endif
int cbmem_reinit(void); int cbmem_reinit(void);

11
src/lib/cbmem.c
View File

@ -256,17 +256,6 @@ BOOT_STATE_INIT_ENTRIES(cbmem_bscb) = {
init_cbmem_post_device, NULL), init_cbmem_post_device, NULL),
}; };
int cbmem_base_check(void)
{
if (!cbmem_base) {
printk(BIOS_ERR, "ERROR: CBMEM Base is not set.\n");
// Are there any boards without?
// Stepan thinks we should die() here!
}
printk(BIOS_DEBUG, "CBMEM Base is %llx.\n", cbmem_base);
return !!cbmem_base;
}
void cbmem_add_lb_mem(struct lb_memory *mem) void cbmem_add_lb_mem(struct lb_memory *mem)
{ {
lb_add_memory_range(mem, LB_MEM_TABLE, cbmem_base, cbmem_size); lb_add_memory_range(mem, LB_MEM_TABLE, cbmem_base, cbmem_size);