From 5b757b597a3e75c6d0d17025288de8d162a77f52 Mon Sep 17 00:00:00 2001 From: Mario Scheithauer Date: Thu, 19 May 2022 12:06:33 +0200 Subject: [PATCH] soc/intel/ehl: Use defines for Ethernet controller IDs Use defines for a better reading of the code. Change-Id: I8e696240d649c0ea2341b8f04b62eebffebc1d57 Signed-off-by: Mario Scheithauer Reviewed-on: https://review.coreboot.org/c/coreboot/+/64519 Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) --- src/include/device/pci_ids.h | 5 +++++ src/soc/intel/elkhartlake/tsn_gbe.c | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 79decbe5a3..ddc055fdf2 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -4482,6 +4482,11 @@ #define PCI_DID_INTEL_MTL_CRASHLOG_SRAM 0x7d0d #define PCI_DID_INTEL_RPL_CPU_CRASHLOG_SRAM 0xa77d +/* Intel Ethernet Controller device Ids */ +#define PCI_DID_INTEL_EHL_GBE_HOST 0x4B32 +#define PCI_DID_INTEL_EHL_GBE_PSE_0 0x4BA0 +#define PCI_DID_INTEL_EHL_GBE_PSE_1 0x4BB0 + #define PCI_VID_COMPUTONE 0x8e0e #define PCI_DID_COMPUTONE_IP2EX 0x0291 #define PCI_DID_COMPUTONE_PG 0x0302 diff --git a/src/soc/intel/elkhartlake/tsn_gbe.c b/src/soc/intel/elkhartlake/tsn_gbe.c index 4d8944a6b4..a90c4af25e 100644 --- a/src/soc/intel/elkhartlake/tsn_gbe.c +++ b/src/soc/intel/elkhartlake/tsn_gbe.c @@ -43,7 +43,12 @@ static struct device_operations gbe_tsn_ops = { .init = gbe_tsn_init, }; -static const unsigned short gbe_tsn_device_ids[] = { 0x4b32, 0x4ba0, 0x4bb0, 0 }; +static const unsigned short gbe_tsn_device_ids[] = { + PCI_DID_INTEL_EHL_GBE_HOST, + PCI_DID_INTEL_EHL_GBE_PSE_0, + PCI_DID_INTEL_EHL_GBE_PSE_1, + 0 +}; static const struct pci_driver gbe_tsn_driver __pci_driver = { .ops = &gbe_tsn_ops,