GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/starlabs/lite: Remove webcam USB port from devicetree 

Remove the Webcam USB port form the devicetree and handle it solely in
devtree, which will enable or disable it based on the CMOS option.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I9c89c7103aca5c3d42215122e9d94c83947b6fee
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64544
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@tutanota.com>
This commit is contained in:
Sean Rhodes 2022-05-20 10:28:39 +01:00 committed by Martin L Roth
parent 07d3668d97
commit 5c0e3d4511
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/starlabs/lite/Kconfig
View File

@ -75,4 +75,9 @@ config UART_FOR_CONSOLE
config VARIANT_DIR config VARIANT_DIR
default "glk" if BOARD_STARLABS_LITE_GLK default "glk" if BOARD_STARLABS_LITE_GLK
default "glkr" if BOARD_STARLABS_LITE_GLKR default "glkr" if BOARD_STARLABS_LITE_GLKR
config WEBCAM_USB_PORT
int
default 4 if BOARD_STARLABS_LITE_GLK
default 7 if BOARD_STARLABS_LITE_GLKR
endif endif

3
src/mainboard/starlabs/lite/devtree.c
View File

@ -47,6 +47,5 @@ void devtree_update(void)
nic_dev->enabled = 0; nic_dev->enabled = 0;
/* Enable/Disable Webcam based on CMOS settings */ /* Enable/Disable Webcam based on CMOS settings */
if (get_uint_option("webcam", 1) == 0) cfg->usb2_port[CONFIG_WEBCAM_USB_PORT].enable = get_uint_option("webcam", 1);
cfg->usb2_port[4].enable = 0;
} }

2
src/mainboard/starlabs/lite/variants/glk/devicetree.cb
View File

@ -89,8 +89,6 @@ chip soc/intel/apollolake
register "usb2_port[0]" = "PORT_EN(OC_SKIP)" register "usb2_port[0]" = "PORT_EN(OC_SKIP)"
# Motherboard USB 3.0 # Motherboard USB 3.0
register "usb2_port[3]" = "PORT_EN(OC1)" register "usb2_port[3]" = "PORT_EN(OC1)"
# Internal Webcam
register "usb2_port[4]" = "PORT_EN(OC_SKIP)"
# Daughterboard USB 3.0 # Daughterboard USB 3.0
register "usb2_port[5]" = "PORT_EN(OC_SKIP)" register "usb2_port[5]" = "PORT_EN(OC_SKIP)"
# Daughterboard SD Card # Daughterboard SD Card

2
src/mainboard/starlabs/lite/variants/glkr/devicetree.cb
View File

@ -91,8 +91,6 @@ chip soc/intel/apollolake
register "usb2_port[3]" = "PORT_EN(OC1)" register "usb2_port[3]" = "PORT_EN(OC1)"
# Daughterboard SD Card # Daughterboard SD Card
register "usb2_port[5]" = "PORT_EN(OC_SKIP)" register "usb2_port[5]" = "PORT_EN(OC_SKIP)"
# Internal Webcam
register "usb2_port[7]" = "PORT_EN(OC_SKIP)"
### USB 3.0 Devices ### USB 3.0 Devices
# Motherboard USB 3.0 # Motherboard USB 3.0