From 5c56b16533313e5d7cce213357fc22a52e14d899 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 17 Jan 2023 02:52:03 +0100 Subject: [PATCH] soc/amd/*/agesa_acpi: add TODO for adding CRAT table The Picasso SoC code generates a CRAT ACPI table which is not done for Cezanne and newer. A significant part of the Picasso CRAT generation code can likely be moved to the common AMD SoC code and then used in all SoCs, but this still needs to be checked. Signed-off-by: Felix Held Change-Id: I8f1ebe74f0376c60396dbd80e64676d1374ed811 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72027 Reviewed-by: Fred Reitberger Tested-by: build bot (Jenkins) --- src/soc/amd/cezanne/agesa_acpi.c | 2 ++ src/soc/amd/glinda/agesa_acpi.c | 2 ++ src/soc/amd/mendocino/agesa_acpi.c | 2 ++ src/soc/amd/phoenix/agesa_acpi.c | 2 ++ 4 files changed, 8 insertions(+) diff --git a/src/soc/amd/cezanne/agesa_acpi.c b/src/soc/amd/cezanne/agesa_acpi.c index ce4753b092..fdfe3eb3d7 100644 --- a/src/soc/amd/cezanne/agesa_acpi.c +++ b/src/soc/amd/cezanne/agesa_acpi.c @@ -12,6 +12,8 @@ uintptr_t agesa_write_acpi_tables(const struct device *device, uintptr_t current { acpi_ivrs_t *ivrs; + /* TODO: look into adding CRAT */ + /* add ALIB SSDT from HOB */ current = acpi_align_current(current); current = add_agesa_fsp_acpi_table(AMD_FSP_ACPI_ALIB_HOB_GUID, "ALIB", rsdp, current); diff --git a/src/soc/amd/glinda/agesa_acpi.c b/src/soc/amd/glinda/agesa_acpi.c index ae4f10284f..7ac19c72de 100644 --- a/src/soc/amd/glinda/agesa_acpi.c +++ b/src/soc/amd/glinda/agesa_acpi.c @@ -14,6 +14,8 @@ uintptr_t agesa_write_acpi_tables(const struct device *device, uintptr_t current { acpi_ivrs_t *ivrs; + /* TODO: look into adding CRAT */ + /* add ALIB SSDT from HOB */ current = acpi_align_current(current); current = add_agesa_fsp_acpi_table(AMD_FSP_ACPI_ALIB_HOB_GUID, "ALIB", rsdp, current); diff --git a/src/soc/amd/mendocino/agesa_acpi.c b/src/soc/amd/mendocino/agesa_acpi.c index 7e85b13b87..d60a79d51f 100644 --- a/src/soc/amd/mendocino/agesa_acpi.c +++ b/src/soc/amd/mendocino/agesa_acpi.c @@ -14,6 +14,8 @@ uintptr_t agesa_write_acpi_tables(const struct device *device, uintptr_t current { acpi_ivrs_t *ivrs; + /* TODO: look into adding CRAT */ + /* add ALIB SSDT from HOB */ current = acpi_align_current(current); current = add_agesa_fsp_acpi_table(AMD_FSP_ACPI_ALIB_HOB_GUID, "ALIB", rsdp, current); diff --git a/src/soc/amd/phoenix/agesa_acpi.c b/src/soc/amd/phoenix/agesa_acpi.c index 3c58a20f58..251acc6c31 100644 --- a/src/soc/amd/phoenix/agesa_acpi.c +++ b/src/soc/amd/phoenix/agesa_acpi.c @@ -15,6 +15,8 @@ uintptr_t agesa_write_acpi_tables(const struct device *device, uintptr_t current { acpi_ivrs_t *ivrs; + /* TODO: look into adding CRAT */ + /* add ALIB SSDT from HOB */ current = acpi_align_current(current); current = add_agesa_fsp_acpi_table(AMD_FSP_ACPI_ALIB_HOB_GUID, "ALIB", rsdp, current);