From 5d029bbb90f63b6cfeb4198ba7b59ca3bf730b32 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 7 Sep 2022 16:08:34 +0100 Subject: [PATCH] mb/starlabs/lite/{glk,glkr}: Adjust THERMTRIP GPIO Modify the configuration of GPIO_74 (PMIC Thermal Trip Point) as in it's current configuration, it stops the laptop entering S5. Signed-off-by: Sean Rhodes Change-Id: I0e31f095ff42a03e3ea1496fe67d69b0f1763a3c Reviewed-on: https://review.coreboot.org/c/coreboot/+/67418 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/mainboard/starlabs/lite/variants/glk/gpio.c | 3 ++- src/mainboard/starlabs/lite/variants/glkr/gpio.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mainboard/starlabs/lite/variants/glk/gpio.c b/src/mainboard/starlabs/lite/variants/glk/gpio.c index f0d008cec9..f24ed9e656 100644 --- a/src/mainboard/starlabs/lite/variants/glk/gpio.c +++ b/src/mainboard/starlabs/lite/variants/glk/gpio.c @@ -169,7 +169,8 @@ const struct pad_config gpio_table[] = { /* GPIO_73: Not Connected */ PAD_NC(GPIO_73, DN_20K), /* GPIO_74: PMIC_THERMTRIP# */ - PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_74, UP_20K, DEEP, NF1, TxDRxE, ENPU), + _PAD_CFG_STRUCT(GPIO_74, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), + PAD_PULL(UP_20K) | PAD_IOSSTATE(IGNORE) | PAD_IOSTERM(ENPU)), /* GPIO_75: PROCHOT#_CPU */ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_75, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* GPIO_211: EMMC_RST#_CPU */ diff --git a/src/mainboard/starlabs/lite/variants/glkr/gpio.c b/src/mainboard/starlabs/lite/variants/glkr/gpio.c index 6bf8b6120d..11a7d31615 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/gpio.c +++ b/src/mainboard/starlabs/lite/variants/glkr/gpio.c @@ -169,7 +169,8 @@ const struct pad_config gpio_table[] = { /* GPIO_73: WiFi Disable */ PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_73, 1, DEEP, NONE, IGNORE, DISPUPD), /* GPIO_74: PMIC_THERMTRIP# */ - PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_74, UP_20K, DEEP, NF1, TxDRxE, ENPU), + _PAD_CFG_STRUCT(GPIO_74, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF), + PAD_PULL(UP_20K) | PAD_IOSSTATE(IGNORE) | PAD_IOSTERM(ENPU)), /* GPIO_75: PROCHOT#_CPU */ PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_75, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* GPIO_211: EMMC_RST#_CPU */