GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/mb/google/tmpl/puff: Fix overridetree.cb to swap USB ports 

Switch USB2 port1 and port3 due to circuit change from rev0.

BUG=b:154071868,b:154585046,b:156429564
BRANCH=none
TEST=none

Change-Id: I5b9a20bd657ed587ec891e52f66629d554df6166
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42676
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
This commit is contained in:
Edward O'Callaghan 2020-06-22 12:00:51 +10:00 committed by Edward O'Callaghan
parent b6737fc54a
commit 5d33d03d3f
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
util/mainboard/google/puff/template/overridetree.cb
View File

@ -21,9 +21,6 @@ chip soc/intel/cannonlake
}" }"
# USB configuration # USB configuration
# NOTE: This only applies to Puff,
# usb2_ports[1] and usb2_ports[3] were swapped on
# reference schematics after Puff has been built.
register "usb2_ports[0]" = "{ register "usb2_ports[0]" = "{
.enable = 1, .enable = 1,
.ocpin = OC2, .ocpin = OC2,
@ -32,7 +29,14 @@ chip soc/intel/cannonlake
.pre_emp_bias = USB2_BIAS_11P25MV, .pre_emp_bias = USB2_BIAS_11P25MV,
.pre_emp_bit = USB2_HALF_BIT_PRE_EMP, .pre_emp_bit = USB2_HALF_BIT_PRE_EMP,
}" # Type-A Port 2 }" # Type-A Port 2
register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Type-C Port register "usb2_ports[1]" = "{
.enable = 1,
.ocpin = OC1,
.tx_bias = USB2_BIAS_0MV,
.tx_emp_enable = USB2_PRE_EMP_ON,
.pre_emp_bias = USB2_BIAS_28P15MV,
.pre_emp_bit = USB2_HALF_BIT_PRE_EMP,
}" # Type-A Port 1
register "usb2_ports[2]" = "{ register "usb2_ports[2]" = "{
.enable = 1, .enable = 1,
.ocpin = OC3, .ocpin = OC3,
@ -41,14 +45,7 @@ chip soc/intel/cannonlake
.pre_emp_bias = USB2_BIAS_28P15MV, .pre_emp_bias = USB2_BIAS_28P15MV,
.pre_emp_bit = USB2_HALF_BIT_PRE_EMP, .pre_emp_bit = USB2_HALF_BIT_PRE_EMP,
}" # Type-A Port 3 }" # Type-A Port 3
register "usb2_ports[3]" = "{ register "usb2_ports[3]" = "USB2_PORT_TYPE_C(OC_SKIP)" # Type-C Port
.enable = 1,
.ocpin = OC1,
.tx_bias = USB2_BIAS_0MV,
.tx_emp_enable = USB2_PRE_EMP_ON,
.pre_emp_bias = USB2_BIAS_28P15MV,
.pre_emp_bit = USB2_HALF_BIT_PRE_EMP,
}" # Type-A Port 1
register "usb2_ports[4]" = "{ register "usb2_ports[4]" = "{
.enable = 1, .enable = 1,
.ocpin = OC_SKIP, .ocpin = OC_SKIP,