GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/guybrush,mancomb: only print warning in mainboard_smi_gpi 

guybrush and mancomb don't configure any GPIO as PAD_SMI. Since
mainboard_smi_gpi will only get called for a GEVENT that will cause a
non-SCI SMI, this isn't expected to be called. For the unexpected and
very unlikely case that it still does get called, put a printk into
mainboard_smi_gpi to see what is happening there.

TEST=none

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ifd6e3348ecc078932bf6cf5b0830b4b034d274bb
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52360
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2021-04-15 01:04:06 +02:00 committed by Martin Roth
parent d6ace2457e
commit 5db62ef94a
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/guybrush/smihandler.c
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h>
#include <console/console.h>
#include <cpu/x86/smm.h>
#include <ec/google/chromeec/ec.h>
#include <ec/google/chromeec/smm.h>
@ -9,7 +10,8 @@
void mainboard_smi_gpi(u32 gpi_sts)
{
chromeec_smi_process_events();
printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being "
"called. gpi_status is %x.\n", __func__, gpi_sts);
}
void mainboard_smi_sleep(u8 slp_typ)

4
src/mainboard/google/mancomb/smihandler.c
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h>
#include <console/console.h>
#include <cpu/x86/smm.h>
#include <ec/google/chromeec/ec.h>
#include <ec/google/chromeec/smm.h>
@ -9,7 +10,8 @@
void mainboard_smi_gpi(u32 gpi_sts)
{
chromeec_smi_process_events();
printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being "
"called. gpi_status is %x.\n", __func__, gpi_sts);
}
void mainboard_smi_sleep(u8 slp_typ)