From 5e20c1cbc841ca2174cdc025fa4ce95d3d717c29 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Sat, 14 Mar 2020 17:36:10 +0100 Subject: [PATCH] util/board-status: Reject logs from dirty images Currently, there are a lot of uploads in the board status repository, where the logs say, that the coreboot image or payload were built from a dirty source tree. Add a check to reject such uploads. Change-Id: I920e26a10f74e1f3b9b4e5f8c9284c59692a519b Signed-off-by: Paul Menzel Reviewed-on: https://review.coreboot.org/c/coreboot/+/39562 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/board_status/board_status.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 6d6854d071..a990ce505e 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -426,6 +426,13 @@ else echo "Getting coreboot boot log" cmd $LOCAL "$cbmem_cmd -1" "${tmpdir}/${results}/coreboot_console.txt" + if [ $(grep -- -dirty "${tmpdir}/${results}/coreboot_console.txt") ]; then + echo "coreboot or the payload are built from a source tree in a" \ + "dirty state, making it hard to reproduce the result. Please" \ + "check in your source tree with 'git status'." + exit $EXIT_FAILURE + fi + echo "Getting timestamp data" cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt"