GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vendorcode/siemens: Fix bug in hwilib for FF_FanReq and FF_FreezeDis 

The two flags FF_FanReq and FF_Freeze_Dis should be treated as
8 bit values and not as 32 bit. Change the length of these fields to
1 byte and adjust the offset and mask for FF_FanReq.

Change-Id: If5e9e8b16491a33997cc39c3dd9b80f97682adc6
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/20431
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Werner Zeh 2017-06-30 10:05:06 +02:00
parent a1de1a0810
commit 5e21cd450c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/vendorcode/siemens/hwilib/hwilib.c
View File

@ -143,14 +143,14 @@ static const struct param_info params[] = {
.pos[0] = {.blk_type = BLK_HIB, .offset = 0xe0, .len = 0x80}, .pos[0] = {.blk_type = BLK_HIB, .offset = 0xe0, .len = 0x80},
.get_field = hwilib_read_bytes }, .get_field = hwilib_read_bytes },
[FF_FreezeDis] = { [FF_FreezeDis] = {
.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 4}, .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 1},
.mask = 0x10, .mask = 0x10,
.mask_offset = 4, .mask_offset = 4,
.get_field = hwilib_read_bytes }, .get_field = hwilib_read_bytes },
[FF_FanReq] = { [FF_FanReq] = {
.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b8, .len = 4}, .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1b9, .len = 1},
.mask = 0x400, .mask = 0x04,
.mask_offset = 10, .mask_offset = 2,
.get_field = hwilib_read_bytes }, .get_field = hwilib_read_bytes },
[NvramVirtTimeDsaveReset] = { [NvramVirtTimeDsaveReset] = {
.pos[0] = {.blk_type = BLK_HIB, .offset = 0x1be, .len = 2}, .pos[0] = {.blk_type = BLK_HIB, .offset = 0x1be, .len = 2},