Intel and GFXUMA: drop redundant use of lb_add_memory_range()
Use of uma_resource() in northbridge code created a memory resource marked as reserved. Such resources are removed from system memory in write_coreboot_table(). Change-Id: I14bfd560140d8d30ec156562f23072bfae747bde Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/1238 Tested-by: build bot (Jenkins) Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
This commit is contained in:
parent
7f189cc74e
commit
5e29f00c55
|
@ -23,7 +23,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -3,7 +3,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -23,7 +23,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -23,7 +23,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -22,7 +22,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -44,7 +44,7 @@ void mainboard_suspend_resume(void)
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
#if defined(CONFIG_PCI_OPTION_ROM_RUN_REALMODE) && CONFIG_PCI_OPTION_ROM_RUN_REALMODE
|
#if defined(CONFIG_PCI_OPTION_ROM_RUN_REALMODE) && CONFIG_PCI_OPTION_ROM_RUN_REALMODE
|
||||||
|
|
|
@ -23,7 +23,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -23,7 +23,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -23,7 +23,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
struct chip_operations mainboard_ops = {
|
struct chip_operations mainboard_ops = {
|
||||||
|
|
|
@ -24,7 +24,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static void mainboard_init(device_t dev)
|
static void mainboard_init(device_t dev)
|
||||||
|
|
|
@ -51,7 +51,7 @@ void mainboard_suspend_resume(void)
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
#if defined(CONFIG_PCI_OPTION_ROM_RUN_REALMODE) && CONFIG_PCI_OPTION_ROM_RUN_REALMODE
|
#if defined(CONFIG_PCI_OPTION_ROM_RUN_REALMODE) && CONFIG_PCI_OPTION_ROM_RUN_REALMODE
|
||||||
|
|
|
@ -44,7 +44,7 @@ void mainboard_suspend_resume(void)
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
#if defined(CONFIG_PCI_OPTION_ROM_RUN_REALMODE) && CONFIG_PCI_OPTION_ROM_RUN_REALMODE
|
#if defined(CONFIG_PCI_OPTION_ROM_RUN_REALMODE) && CONFIG_PCI_OPTION_ROM_RUN_REALMODE
|
||||||
|
|
|
@ -30,7 +30,7 @@
|
||||||
|
|
||||||
int add_mainboard_resources(struct lb_memory *mem)
|
int add_mainboard_resources(struct lb_memory *mem)
|
||||||
{
|
{
|
||||||
return add_northbridge_resources(mem);
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
// setting the bit disables the led.
|
// setting the bit disables the led.
|
||||||
|
|
|
@ -62,15 +62,6 @@ static const struct pci_driver i810e_northbridge_driver __pci_driver = {
|
||||||
.device = 0x7124,
|
.device = 0x7124,
|
||||||
};
|
};
|
||||||
|
|
||||||
int add_northbridge_resources(struct lb_memory *mem)
|
|
||||||
{
|
|
||||||
printk(BIOS_DEBUG, "Adding IGD UMA memory area\n");
|
|
||||||
lb_add_memory_range(mem, LB_MEM_RESERVED,
|
|
||||||
uma_memory_base, uma_memory_size);
|
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Table which returns the RAM size in MB when fed the DRP[7:4] or [3:0] value.
|
/* Table which returns the RAM size in MB when fed the DRP[7:4] or [3:0] value.
|
||||||
* Note that 2 is a value which the DRP should never be programmed to.
|
* Note that 2 is a value which the DRP should never be programmed to.
|
||||||
* Some size values appear twice, due to single-sided vs dual-sided banks.
|
* Some size values appear twice, due to single-sided vs dual-sided banks.
|
||||||
|
|
|
@ -52,15 +52,6 @@ static const struct pci_driver northbridge_driver __pci_driver = {
|
||||||
.device = 0x3575,
|
.device = 0x3575,
|
||||||
};
|
};
|
||||||
|
|
||||||
int add_northbridge_resources(struct lb_memory *mem)
|
|
||||||
{
|
|
||||||
printk(BIOS_DEBUG, "Adding IGD UMA memory area\n");
|
|
||||||
lb_add_memory_range(mem, LB_MEM_RESERVED,
|
|
||||||
uma_memory_base, uma_memory_size);
|
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
#if CONFIG_WRITE_HIGH_TABLES
|
#if CONFIG_WRITE_HIGH_TABLES
|
||||||
#include <cbmem.h>
|
#include <cbmem.h>
|
||||||
#endif
|
#endif
|
||||||
|
|
|
@ -61,11 +61,6 @@ int bridge_silicon_revision(void)
|
||||||
static const int legacy_hole_base_k = 0xa0000 / 1024;
|
static const int legacy_hole_base_k = 0xa0000 / 1024;
|
||||||
static const int legacy_hole_size_k = 384;
|
static const int legacy_hole_size_k = 384;
|
||||||
|
|
||||||
int add_northbridge_resources(struct lb_memory *mem)
|
|
||||||
{
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
void cbmem_post_handling(void)
|
void cbmem_post_handling(void)
|
||||||
{
|
{
|
||||||
update_mrc_cache();
|
update_mrc_cache();
|
||||||
|
|
Loading…
Reference in New Issue