From 5e2a42ae3288e1054fe367bee27f3894a7300f33 Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Tue, 5 Jun 2007 12:51:52 +0000 Subject: [PATCH] Move GPIO settings to board specific code for IBM x3455 Signed-off-by: Stefan Reinauer Acked-by: Stefan Reinauer git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2712 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- util/flashrom/board_enable.c | 14 ++++++++++++++ util/flashrom/chipset_enable.c | 5 ----- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/util/flashrom/board_enable.c b/util/flashrom/board_enable.c index 27d2d01988..852da40dad 100644 --- a/util/flashrom/board_enable.c +++ b/util/flashrom/board_enable.c @@ -246,6 +246,18 @@ static int board_asus_p5a(const char *name) return 0; } +static int board_ibm_x3455(const char *name) +{ + uint8_t byte; + + /* Set GPIO lines in HT1000 southbridge */ + outb(0x45, 0xcd6); + byte = inb(0xcd7); + outb(byte|0x20, 0xcd7); + + return 0; +} + /* * We use 2 sets of ids here, you're free to choose which is which. This * to provide a very high degree of certainty when matching a board on @@ -290,6 +302,8 @@ struct board_pciid_enable board_pciid_enables[] = { NULL, NULL, "ASUS A7V8-MX SE", board_asus_a7v8x_mx}, {0x10B9, 0x1541, 0x0000, 0x0000, 0x10B9, 0x1533, 0x0000, 0x0000, "asus", "p5a", "ASUS P5A", board_asus_p5a}, + {0x1166, 0x0205, 0x1014, 0x0347, 0x0000, 0x0000, 0x0000, 0x0000, + "ibm", "x3455", "IBM x3455", board_ibm_x3455}, {0, 0, 0, 0, 0, 0, 0, 0, NULL, NULL} /* Keep this */ }; diff --git a/util/flashrom/chipset_enable.c b/util/flashrom/chipset_enable.c index b663295770..3e532447e6 100644 --- a/util/flashrom/chipset_enable.c +++ b/util/flashrom/chipset_enable.c @@ -401,11 +401,6 @@ static int enable_flash_ht1000(struct pci_dev *dev, char *name) byte |= (1<<4); pci_write_byte(dev, 0x43, byte); - /* Some magic. Comment me if you can */ - outb(0x45, 0xcd6); - byte = inb(0xcd7); - outb(reg8|0x20, 0xcd7); - return 0; }