GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: Demote LPC EC error printk from ERR to SPEW 

Several EC host commands check for support of a given feature or msg
version, and a non-zero response does not necessarily indicate an actual
error. Since the caller is (should be) handling the non-zero response to
the host command, demote the EC printk from ERR to SPEW to clean up the
console log and prevent non-errors from causing false failures in
firmware tests.

BUG=b:238961053

Change-Id: Ib7afc0b7e5b571acb56252f7adb518a6b2716b62
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68259
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2022-10-10 13:55:58 -05:00 committed by Felix Held
parent fec16a3574
commit 5e2f1b1e64
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ec/google/chromeec/ec_lpc.c
View File

@ -239,7 +239,7 @@ static int google_chromeec_command_v3(struct chromeec_command *cec_command)
/* Check result */ /* Check result */
cec_command->cmd_code = read_byte(EC_LPC_ADDR_HOST_DATA); cec_command->cmd_code = read_byte(EC_LPC_ADDR_HOST_DATA);
if (cec_command->cmd_code) { if (cec_command->cmd_code) {
printk(BIOS_ERR, "EC returned error result code %d\n", printk(BIOS_SPEW, "EC returned error result code %d\n",
cec_command->cmd_code); cec_command->cmd_code);
return -i; return -i;
} }