From 5e6ff46745af8f538f3a6a8d46b388fc80f55faa Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 21 Feb 2023 23:00:55 +0100 Subject: [PATCH] soc/amd/picasso,stoneyridge/acpi: drop unneeded ARM_boot_arch assignment The FADT data structure is zero-initialized in acpi_create_fadt which then calls the SoC-specific acpi_fill_fadt function, therefore it's not needed to assign 0 to the ARM_boot_arch FADT field in acpi_fill_fadt. Signed-off-by: Felix Held Change-Id: Ica968db1228a2d63e83f2b6c4ea57c5f02bf1504 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73187 Reviewed-by: Elyes Haouas Tested-by: build bot (Jenkins) Reviewed-by: Fred Reitberger --- src/soc/amd/picasso/acpi.c | 2 -- src/soc/amd/stoneyridge/acpi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index 48b56f584f..125aa0aa65 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -100,8 +100,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_REMOTE_POWER_ON; fadt->flags |= cfg->fadt_flags; /* additional board-specific flags */ - fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; } diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index be9349d096..40976af654 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -91,8 +91,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON; - fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; }