GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake: Do not use StackBase FSP-M parameter 

Currently, StackBase field doesn't work and changing it from default
value leads to crash.

Change-Id: Id3f3ea9a834d0c04a8381938535109d6a729cca2
Signed-off-by: Andrey Petrov <andrey.petrov@intel.com>
Reviewed-on: https://review.coreboot.org/14803
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Andrey Petrov 2016-04-15 21:32:30 -07:00 committed by Aaron Durbin
parent 9be1a115f1
commit 5ede3d8cce
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/apollolake/romstage.c
View File

@ -238,9 +238,13 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd)
* requests. * requests.
* TODO: add checks to avoid overlap/conflict of CAR usage. * TODO: add checks to avoid overlap/conflict of CAR usage.
*/ */
/* fsp does not work with StackBase modified, so use default */
#if 0
/* FIXME: remove this once FSP is fixed */
mupd->FspmArchUpd.StackBase = _car_region_end - mupd->FspmArchUpd.StackBase = _car_region_end -
mupd->FspmArchUpd.StackSize; mupd->FspmArchUpd.StackSize;
#endif
arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION; arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION;
if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) { if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {