From 5ef5c00704ac902f33f52e8daa4f3167cf1000ba Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Fri, 24 Mar 2017 11:08:32 -0600 Subject: [PATCH] mb/lenovo/s230u: Fix USBDEBUG check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Change preprocessor #if to standard C if. This will get optimized out if the config option is disabled, but lets the compiler check the contents. - CONFIG_USBDEBUG is always going to be defined even if it's disabled, so this check is not going to work as expected. See the coreboot Kconfig documentation in /Documentation/core/Kconfig.md Change-Id: Ia63438d9525e79307d9229ad3ffa2962978611d8 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/18974 Reviewed-by: Patrick Georgi Reviewed-by: Philippe Mathieu-Daudé Tested-by: build bot (Jenkins) --- src/mainboard/lenovo/s230u/romstage.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mainboard/lenovo/s230u/romstage.c b/src/mainboard/lenovo/s230u/romstage.c index ce751653c2..ad5f02187f 100644 --- a/src/mainboard/lenovo/s230u/romstage.c +++ b/src/mainboard/lenovo/s230u/romstage.c @@ -51,10 +51,9 @@ void pch_enable_lpc(void) CONFIG_EC_BASE_ADDRESS | 1); pci_write_config16(PCI_DEV(0, 0x1f, 0), 0xd8, 0xffc0); - #ifdef CONFIG_USBDEBUG /* Enable external USB port power. */ - ec_mm_set_bit(0x3b, 4); - #endif + if (IS_ENABLED(CONFIG_USBDEBUG)) + ec_mm_set_bit(0x3b, 4); } void rcba_config(void)