GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/tigerlake: Replace SOC_INTEL_TIGERLAKE_S3 with D3COLD_SUPPORT 

The Kconfig option SOC_INTEL_TIGERLAKE_S3 suggests that it's doing
something with S3, but it's actually disabling D3Cold support.

Remove it, and instead use D3COLD_SUPPORT so it's clear what the
option is doing.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: Id43f3e5c8620d474831cc02fcecebd8aac961687
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74405
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sean Rhodes 2023-04-13 12:17:38 +01:00 committed by Lean Sheng Tan
parent aa8c6a22e5
commit 5f0cda7e91
6 changed files with 18 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/starlabs/starbook/Kconfig
View File

@ -48,7 +48,6 @@ config BOARD_STARLABS_STARBOOK_TGL
select SOC_INTEL_COMMON_BLOCK_TCSS select SOC_INTEL_COMMON_BLOCK_TCSS
select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES
select SOC_INTEL_TIGERLAKE select SOC_INTEL_TIGERLAKE
select SOC_INTEL_TIGERLAKE_S3
select SPI_FLASH_WINBOND select SPI_FLASH_WINBOND
select TPM_MEASURED_BOOT select TPM_MEASURED_BOOT

6
src/soc/intel/tigerlake/Kconfig
View File

@ -208,12 +208,6 @@ config SOC_INTEL_I2C_DEV_MAX
int int
default 6 default 6
config SOC_INTEL_TIGERLAKE_S3
bool
default n
help
Select if using S3 instead of S0ix to disable D3Cold
config SOC_INTEL_UART_DEV_MAX config SOC_INTEL_UART_DEV_MAX
int int
default 3 default 3

4
src/soc/intel/tigerlake/acpi/tcss.asl
View File

@ -676,7 +676,7 @@ Scope (\_SB.PCI0)
} }
} }
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
Method (TCON, 0) Method (TCON, 0)
{ {
/* Reset IOM D3 cold bit if it is in D3 cold now. */ /* Reset IOM D3 cold bit if it is in D3 cold now. */
@ -787,7 +787,7 @@ Scope (\_SB.PCI0)
STAT = 0 STAT = 0
} }
} }
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
/* /*
* TCSS xHCI device * TCSS xHCI device

12
src/soc/intel/tigerlake/acpi/tcss_dma.asl
View File

@ -27,11 +27,11 @@ Name (STAT, 0x1) /* Variable to save power state 1 - D0, 0 - D3C */
Method (_S0W, 0x0) Method (_S0W, 0x0)
{ {
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
Return (0x04) Return (0x04)
#else #else
Return (0x03) Return (0x03)
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
} }
/* /*
@ -40,7 +40,7 @@ Method (_S0W, 0x0)
*/ */
Method (_PR0) Method (_PR0)
{ {
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
If (DUID == 0) { If (DUID == 0) {
Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 }) Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 })
} Else { } Else {
@ -52,12 +52,12 @@ Method (_PR0)
} Else { } Else {
Return (Package() { \_SB.PCI0.TBT1 }) Return (Package() { \_SB.PCI0.TBT1 })
} }
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
} }
Method (_PR3) Method (_PR3)
{ {
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
If (DUID == 0) { If (DUID == 0) {
Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 }) Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 })
} Else { } Else {
@ -69,7 +69,7 @@ Method (_PR3)
} Else { } Else {
Return (Package() { \_SB.PCI0.TBT1 }) Return (Package() { \_SB.PCI0.TBT1 })
} }
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
} }
/* /*

12
src/soc/intel/tigerlake/acpi/tcss_pcierp.asl
View File

@ -247,16 +247,16 @@ Method (_PS3, 0, Serialized)
Method (_S0W, 0x0, NotSerialized) Method (_S0W, 0x0, NotSerialized)
{ {
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
Return (0x4) Return (0x4)
#else #else
Return (0x3) Return (0x3)
#endif // SOC_INTEL_ALDERLAKE_S3 #endif // D3COLD_SUPPORT
} }
Method (_PR0) Method (_PR0)
{ {
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
If ((TUID == 0) || (TUID == 1)) { If ((TUID == 0) || (TUID == 1)) {
Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 }) Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 })
} Else { } Else {
@ -268,12 +268,12 @@ Method (_PR0)
} Else { } Else {
Return (Package() { \_SB.PCI0.TBT1 }) Return (Package() { \_SB.PCI0.TBT1 })
} }
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
} }
Method (_PR3) Method (_PR3)
{ {
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
If ((TUID == 0) || (TUID == 1)) { If ((TUID == 0) || (TUID == 1)) {
Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 }) Return (Package() { \_SB.PCI0.D3C, \_SB.PCI0.TBT0 })
} Else { } Else {
@ -285,7 +285,7 @@ Method (_PR3)
} Else { } Else {
Return (Package() { \_SB.PCI0.TBT1 }) Return (Package() { \_SB.PCI0.TBT1 })
} }
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
} }
/* /*

8
src/soc/intel/tigerlake/acpi/tcss_xhci.asl
View File

@ -30,11 +30,11 @@ Method (_PS3, 0, Serialized)
Method (_S0W, 0x0, NotSerialized) Method (_S0W, 0x0, NotSerialized)
{ {
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
Return (0x4) Return (0x4)
#else #else
Return (0x3) Return (0x3)
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
} }
/* /*
@ -43,7 +43,7 @@ Method (_S0W, 0x0, NotSerialized)
*/ */
Name (SD3C, 0) Name (SD3C, 0)
#if !CONFIG(SOC_INTEL_TIGERLAKE_S3) #if CONFIG(D3COLD_SUPPORT)
Method (_PR0) Method (_PR0)
{ {
Return (Package () { \_SB.PCI0.D3C }) Return (Package () { \_SB.PCI0.D3C })
@ -53,7 +53,7 @@ Method (_PR3)
{ {
Return (Package () { \_SB.PCI0.D3C }) Return (Package () { \_SB.PCI0.D3C })
} }
#endif // SOC_INTEL_TIGERLAKE_S3 #endif // D3COLD_SUPPORT
/* /*
* XHCI controller _DSM method * XHCI controller _DSM method