GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable` 

Similar to the discussion on the coreboot list [1]

    Am Freitag, den 22.02.2013, 02:17 +0100 schrieb Peter Stuge:

    […]

    > Function names should try to be descriptive. "enable_dev" is not very
    > descriptive. I like "mainboard_enable" because it makes output such
    > as
    >
    > printk("%s: foo", __func__);
    >
    > useful.

rename the function for the northbridge to `northbridge_enable`.

[1] http://www.coreboot.org/pipermail/coreboot/2013-February/074549.html

Change-Id: I262311ec511e394550330214621b8c37780c1d4e
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/2496
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martin.roth@se-eng.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Paul Menzel 2013-02-24 14:27:03 +01:00 committed by Stefan Reinauer
parent 30901baabc
commit 5f20b35222
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/emulation/qemu-x86/northbridge.c
View File

@ -135,7 +135,7 @@ static struct device_operations pci_domain_ops = {
#endif #endif
}; };
static void enable_dev(struct device *dev) static void northbridge_enable(struct device *dev)
{ {
/* Set the operations if it is a special bus type */ /* Set the operations if it is a special bus type */
if (dev->path.type == DEVICE_PATH_DOMAIN) { if (dev->path.type == DEVICE_PATH_DOMAIN) {
@ -146,5 +146,5 @@ static void enable_dev(struct device *dev)
struct chip_operations mainboard_emulation_qemu_x86_ops = { struct chip_operations mainboard_emulation_qemu_x86_ops = {
CHIP_NAME("QEMU Northbridge") CHIP_NAME("QEMU Northbridge")
.enable_dev = enable_dev, .enable_dev = northbridge_enable,
}; };