From 5f772a6ed33d72233aaf0dd477e45540e187b3d7 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 3 May 2022 02:22:49 +0200 Subject: [PATCH] soc/amd/common/block/psp/psp_gen2: move CORE_2_PSP_MSG_38 defines CORE_2_PSP_MSG_38_OFFSET and CORE_2_PSP_MSG_38_FUSE_SPL are only used in psp_gen2.c, so move them into this file. Signed-off-by: Felix Held Change-Id: I67cc2ff63d1c0322b514521975f3ce0f9b1cf5b1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64011 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Paul Menzel Reviewed-by: Fred Reitberger --- src/soc/amd/common/block/psp/psp_def.h | 3 --- src/soc/amd/common/block/psp/psp_gen2.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/soc/amd/common/block/psp/psp_def.h b/src/soc/amd/common/block/psp/psp_def.h index f171efe116..4d860ff276 100644 --- a/src/soc/amd/common/block/psp/psp_def.h +++ b/src/soc/amd/common/block/psp/psp_def.h @@ -26,9 +26,6 @@ #define MBOX_BIOS_CMD_SMU_FW 0x19 #define MBOX_BIOS_CMD_SMU_FW2 0x1a -#define CORE_2_PSP_MSG_38_OFFSET 0x10998 -#define CORE_2_PSP_MSG_38_FUSE_SPL BIT(12) - /* command/response format, BIOS builds this in memory * mbox_buffer_header: generic header * mbox_buffer: command-specific buffer format diff --git a/src/soc/amd/common/block/psp/psp_gen2.c b/src/soc/amd/common/block/psp/psp_gen2.c index 12f5fec5bf..80650cb8fd 100644 --- a/src/soc/amd/common/block/psp/psp_gen2.c +++ b/src/soc/amd/common/block/psp/psp_gen2.c @@ -13,6 +13,9 @@ #define PSP_MAILBOX_COMMAND_OFFSET 0x10570 /* 4 bytes */ #define PSP_MAILBOX_BUFFER_OFFSET 0x10574 /* 8 bytes */ +#define CORE_2_PSP_MSG_38_OFFSET 0x10998 /* 4 byte */ +#define CORE_2_PSP_MSG_38_FUSE_SPL BIT(12) + union pspv2_mbox_command { u32 val; struct pspv2_mbox_cmd_fields {