From 5ff6a6af0e93a8ad9383bc4c7db079b40133b0d2 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Sat, 2 Nov 2019 17:06:28 +0100 Subject: [PATCH] mb/intel/{i82801gx,x4x}: Don't select ASPM options These are likely not properly set up and L1 is not even supported on the desktop variant of the southbridge. This fixes observed instability on some PCIe GPUs. Change-Id: I70d3536984342614a6ef04a45bc6591e358e3abe Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/36576 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- src/mainboard/asrock/g41c-gs/Kconfig | 3 --- src/mainboard/asus/p5qpl-am/Kconfig | 3 --- src/mainboard/foxconn/g41s-k/Kconfig | 3 --- src/mainboard/intel/dg41wv/Kconfig | 3 --- src/mainboard/lenovo/thinkcentre_a58/Kconfig | 3 --- 5 files changed, 15 deletions(-) diff --git a/src/mainboard/asrock/g41c-gs/Kconfig b/src/mainboard/asrock/g41c-gs/Kconfig index e7cbf7aeb1..81b0995988 100644 --- a/src/mainboard/asrock/g41c-gs/Kconfig +++ b/src/mainboard/asrock/g41c-gs/Kconfig @@ -30,9 +30,6 @@ config BOARD_SPECIFIC_OPTIONS || BOARD_ASROCK_G41M_VS3_R2_0 select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/asus/p5qpl-am/Kconfig b/src/mainboard/asus/p5qpl-am/Kconfig index 7eee9cddca..7cdfea9048 100644 --- a/src/mainboard/asus/p5qpl-am/Kconfig +++ b/src/mainboard/asus/p5qpl-am/Kconfig @@ -25,9 +25,6 @@ config BOARD_SPECIFIC_OPTIONS select SUPERIO_WINBOND_W83627DHG select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/foxconn/g41s-k/Kconfig b/src/mainboard/foxconn/g41s-k/Kconfig index f74fcd6bf3..3597e4c82f 100644 --- a/src/mainboard/foxconn/g41s-k/Kconfig +++ b/src/mainboard/foxconn/g41s-k/Kconfig @@ -29,9 +29,6 @@ config BOARD_SPECIFIC_OPTIONS select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select MAINBOARD_HAS_LPC_TPM - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_LIBGFXINIT diff --git a/src/mainboard/intel/dg41wv/Kconfig b/src/mainboard/intel/dg41wv/Kconfig index 373f6fa0c8..74c7d5270c 100644 --- a/src/mainboard/intel/dg41wv/Kconfig +++ b/src/mainboard/intel/dg41wv/Kconfig @@ -25,9 +25,6 @@ config BOARD_SPECIFIC_OPTIONS select SUPERIO_WINBOND_W83627DHG select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_2048 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME diff --git a/src/mainboard/lenovo/thinkcentre_a58/Kconfig b/src/mainboard/lenovo/thinkcentre_a58/Kconfig index fc1c6a7934..6d8b3dcd39 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/Kconfig +++ b/src/mainboard/lenovo/thinkcentre_a58/Kconfig @@ -25,9 +25,6 @@ config BOARD_SPECIFIC_OPTIONS select SUPERIO_SMSC_SMSCSUPERIO select HAVE_ACPI_TABLES select BOARD_ROMSIZE_KB_1024 - select PCIEXP_ASPM - select PCIEXP_CLK_PM - select PCIEXP_L1_SUB_STATE select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT select HAVE_ACPI_RESUME