GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/kontron/986lcd-m: Use ''PNP_IDX_*' instead of magic numbers 

Change-Id: Ic7c1b4defa8c65ed739b1cf3861087cd53cd997c
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44838
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Elyes HAOUAS 2020-08-26 20:04:32 +02:00 committed by Felix Held
parent e1b1bc94c8
commit 600e70dd52
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mainboard/kontron/986lcd-m/early_init.c
View File

@ -63,7 +63,7 @@ void bootblock_mainboard_early_init(void)
dev = PNP_DEV(0x2e, W83627THG_GAME_MIDI_GPIO1);
pnp_set_logical_device(dev);
pnp_set_enable(dev, 0);
pnp_write_config(dev, 0xf5, 0xff); /* invert all GPIOs */
pnp_write_config(dev, PNP_IDX_MSC5, 0xff); /* invert all GPIOs */
pnp_set_enable(dev, 1);
dev = PNP_DEV(0x2e, W83627THG_GPIO2);
@ -73,9 +73,10 @@ void bootblock_mainboard_early_init(void)
dev = PNP_DEV(0x2e, W83627THG_GPIO3);
pnp_set_logical_device(dev);
pnp_set_enable(dev, 0);
pnp_write_config(dev, 0xf0, 0xfb); /* GPIO bit 2 is output */
pnp_write_config(dev, 0xf1, 0x00); /* GPIO bit 2 is 0 */
pnp_write_config(dev, 0x30, 0x03); /* Enable GPIO3+4. pnp_set_enable is not sufficient */
pnp_write_config(dev, PNP_IDX_MSC0, 0xfb); /* GPIO bit 2 is output */
pnp_write_config(dev, PNP_IDX_MSC1, 0x00); /* GPIO bit 2 is 0 */
/* Enable GPIO3+4. pnp_set_enable is not sufficient */
pnp_write_config(dev, PNP_IDX_EN, 0x03);
dev = PNP_DEV(0x2e, W83627THG_FDC);
pnp_set_logical_device(dev);