GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

armv7/snow: Remove redundant I2C initialization calls in bootblock. 

The I2C initialization (on component MAX77688) is already done in power_init, so
we should not need an explicit call inside bootblock.

Verified to boot on armv7/snow.

Change-Id: I68c248a8b5fee4ab838b2fb708649e112559cc41
Signed-off-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-on: http://review.coreboot.org/2316
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Hung-Te Lin 2013-02-07 21:15:42 +08:00 committed by Ronald G. Minnich
parent 5f83f6cb7a
commit 60485a3e91
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/google/snow/bootblock.c
View File

@ -23,15 +23,12 @@
#include <cbfs.h> #include <cbfs.h>
#include <uart.h> #include <uart.h>
#include <console/console.h> #include <console/console.h>
#include <device/i2c.h>
#include <cpu/samsung/exynos5250/clk.h> #include <cpu/samsung/exynos5250/clk.h>
#include <cpu/samsung/exynos5250/dmc.h> #include <cpu/samsung/exynos5250/dmc.h>
#include <cpu/samsung/exynos5250/periph.h> #include <cpu/samsung/exynos5250/periph.h>
#include <cpu/samsung/exynos5250/clock_init.h> #include <cpu/samsung/exynos5250/clock_init.h>
#include <src/cpu/samsung/exynos5250/power.h> #include <src/cpu/samsung/exynos5250/power.h>
#include <drivers/maxim/max77686/max77686.h>
#define I2C0_BASE 0x12c60000
#endif #endif
void bootblock_mainboard_init(void); void bootblock_mainboard_init(void);
@ -40,8 +37,6 @@ void bootblock_mainboard_init(void)
struct mem_timings *mem; struct mem_timings *mem;
struct arm_clk_ratios *arm_ratios; struct arm_clk_ratios *arm_ratios;
i2c_set_early_reg(I2C0_BASE);
i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
power_init(); power_init();
mem = get_mem_timings(); mem = get_mem_timings();
arm_ratios = get_arm_clk_ratios(); arm_ratios = get_arm_clk_ratios();