GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/emulation/qemu/bochs: Fix the MMIO access to the VGA ioports 

The Bochs graphics adapter remaps the legacy VGA ioports
(0x3c0 -> 0x3df) to its MMIO region at offsets 0400 - 041f.
Currently bochs_vga_write() calculates a wrong offset when
accessing these ioports, which causes the boot splash image
not displayed when using the legacy-free pci variant of the
Bochs graphics adapter.

TEST=Build coreboot for QEMU x86 i440fx with a boot splash image
included, boot coreboot.rom with QEMU with '-device secondary-vga'
and verify the boot splash image is correctly displayed.

Fixes: efaf1b32ba ("drivers/emulation/qemu/bochs: Rewrite driver")
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Change-Id: I4acc71e3d6ef5161ab62e6714c94b7643c4c0972
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75146
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Bin Meng 2023-05-12 17:55:46 +08:00 committed by Felix Singer
parent 53b1929e83
commit 60ee6fa398
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/drivers/emulation/qemu/bochs.c
View File

@ -67,7 +67,7 @@ static void bochs_vga_write(struct resource *res, int index, uint8_t val)
if (res->flags & IORESOURCE_IO) if (res->flags & IORESOURCE_IO)
outb(val, index + 0x3c0); outb(val, index + 0x3c0);
else else
write8(res2mmio(res, (0x400 - 0x3c0) + index, 0), val); write8(res2mmio(res, 0x400 + index, 0), val);
} }
static struct resource res_legacy = { static struct resource res_legacy = {