From 6117a2d296d8b8648b12f0941fa8d0999dc22aa6 Mon Sep 17 00:00:00 2001 From: Johannes Hahn Date: Tue, 25 Jul 2023 13:17:44 +0200 Subject: [PATCH] mb/siemens/fa_ehl: Remove RTC RV3028C7 Delete this RTC from the configuration as fa_ehl mainboard uses a different real time clock. Signed-off-by: Johannes Hahn Change-Id: Ifd6b68d05a094cb4c890f1ffce62d89b771e23c3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77352 Tested-by: build bot (Jenkins) Reviewed-by: Jan Samek Reviewed-by: Uwe Poeche --- .../siemens/fa_ehl/variants/fa_ehl/Kconfig | 1 - .../siemens/fa_ehl/variants/fa_ehl/devicetree.cb | 15 +-------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig index b57abc493f..6f315f7336 100644 --- a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig +++ b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/Kconfig @@ -2,7 +2,6 @@ if BOARD_SIEMENS_FA_EHL config BOARD_SPECIFIC_OPTIONS def_bool y - select DRIVERS_I2C_RV3028C7 select DRIVER_INTEL_I210 select EHL_TSN_DRIVER select DRIVERS_ETH_PHY_M88E1512 diff --git a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/devicetree.cb b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/devicetree.cb index bc6958d88b..5bc393189b 100644 --- a/src/mainboard/siemens/fa_ehl/variants/fa_ehl/devicetree.cb +++ b/src/mainboard/siemens/fa_ehl/variants/fa_ehl/devicetree.cb @@ -143,20 +143,7 @@ chip soc/intel/elkhartlake device pci 14.0 on end # USB3.1 xHCI device pci 15.0 on end # I2C0 - device pci 15.1 on # I2C1 - # Enable external RTC chip - chip drivers/i2c/rv3028c7 - register "bus_speed" = "I2C_SPEED_STANDARD" - register "set_user_date" = "1" - register "user_year" = "04" - register "user_month" = "07" - register "user_day" = "01" - register "user_weekday" = "4" - register "bckup_sw_mode" = "BACKUP_SW_LEVEL" - register "cap_charge" = "CHARGE_OFF" - device i2c 0x52 on end # RTC RV3028-C7 - end - end + device pci 15.1 off end # I2C1 device pci 15.2 on # I2C2 # Add dummy I2C device to limit BUS speed to 100 kHz in OS chip drivers/i2c/generic