GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/noncar/cpu: simplify get_reserved_phys_addr_bits 

Simplify the code a bit by returning 0 early in the function when the
SYSCFG_MSR_SMEE bit isn't set.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Jeremy Compostella <jeremy.compostella@intel.com>
Change-Id: I7536b82d98e55c51105448090d1206e1ed7f62d8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78176
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2023-09-28 20:28:40 +02:00
parent 89ca478843
commit 614568ec58
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/amd/common/block/cpu/noncar/cpu.c
View File

@ -38,10 +38,9 @@ void set_cstate_io_addr(void)
/* Number of most significant physical address bits reserved for secure memory encryption */ /* Number of most significant physical address bits reserved for secure memory encryption */
unsigned int get_reserved_phys_addr_bits(void) unsigned int get_reserved_phys_addr_bits(void)
{ {
if (rdmsr(SYSCFG_MSR).raw & SYSCFG_MSR_SMEE) if (!(rdmsr(SYSCFG_MSR).raw & SYSCFG_MSR_SMEE))
return (cpuid_ebx(CPUID_EBX_MEM_ENCRYPT) &
CPUID_EBX_MEM_ENCRYPT_ADDR_BITS_MASK) >>
CPUID_EBX_MEM_ENCRYPT_ADDR_BITS_SHIFT;
else
return 0; return 0;
return (cpuid_ebx(CPUID_EBX_MEM_ENCRYPT) & CPUID_EBX_MEM_ENCRYPT_ADDR_BITS_MASK) >>
CPUID_EBX_MEM_ENCRYPT_ADDR_BITS_SHIFT;
} }