GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/baytrail/pmutil.c: Do not hardcode num_bits 

This can result in accesses outside array bounds. Copy what Braswell
does, which is slightly safer.

Change-Id: If3d6f4e1f8921f0be7f4e5e438b7e73c46b8ef95
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43183
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Wim Vervoorn <wvervoorn@eltan.com>
This commit is contained in:
Angel Pons 2020-07-07 18:01:46 +02:00
parent 26b49cc9a3
commit 61dee5c865
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/soc/intel/baytrail/pmutil.c
View File

@ -60,11 +60,6 @@ static void print_num_status_bits(int num_bits, uint32_t status,
} }
} }
static void print_status_bits(uint32_t status, const char *bit_names[])
{
print_num_status_bits(32, status, bit_names);
}
static uint32_t print_smi_status(uint32_t smi_sts) static uint32_t print_smi_status(uint32_t smi_sts)
{ {
static const char *smi_sts_bits[] = { static const char *smi_sts_bits[] = {
@ -91,7 +86,7 @@ static uint32_t print_smi_status(uint32_t smi_sts)
return 0; return 0;
printk(BIOS_DEBUG, "SMI_STS: "); printk(BIOS_DEBUG, "SMI_STS: ");
print_status_bits(smi_sts, smi_sts_bits); print_num_status_bits(30, smi_sts, smi_sts_bits);
printk(BIOS_DEBUG, "\n"); printk(BIOS_DEBUG, "\n");
return smi_sts; return smi_sts;
@ -167,7 +162,7 @@ static uint16_t print_pm1_status(uint16_t pm1_sts)
return 0; return 0;
printk(BIOS_SPEW, "PM1_STS: "); printk(BIOS_SPEW, "PM1_STS: ");
print_status_bits(pm1_sts, pm1_sts_bits); print_num_status_bits(16, pm1_sts, pm1_sts_bits);
printk(BIOS_SPEW, "\n"); printk(BIOS_SPEW, "\n");
return pm1_sts; return pm1_sts;
@ -194,7 +189,7 @@ static uint32_t print_tco_status(uint32_t tco_sts)
return 0; return 0;
printk(BIOS_DEBUG, "TCO_STS: "); printk(BIOS_DEBUG, "TCO_STS: ");
print_status_bits(tco_sts, tco_sts_bits); print_num_status_bits(18, tco_sts, tco_sts_bits);
printk(BIOS_DEBUG, "\n"); printk(BIOS_DEBUG, "\n");
return tco_sts; return tco_sts;
@ -281,7 +276,7 @@ static uint32_t print_gpe_sts(uint32_t gpe_sts)
return gpe_sts; return gpe_sts;
printk(BIOS_DEBUG, "GPE0a_STS: "); printk(BIOS_DEBUG, "GPE0a_STS: ");
print_status_bits(gpe_sts, gpe_sts_bits); print_num_status_bits(32, gpe_sts, gpe_sts_bits);
printk(BIOS_DEBUG, "\n"); printk(BIOS_DEBUG, "\n");
return gpe_sts; return gpe_sts;