GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/amd/cimx/sb800: Remove unused variable 

scan-build from Clang 4.0.1-3 from Debian Sid/unstable warns about the
issue below.

```
    CC         ramstage/southbridge/amd/cimx/sb800/lpc.o
src/southbridge/amd/cimx/sb800/lpc.c:102:6: warning: Value stored to 'end' is never read
                                        end = resource_end(res);
                                        ^     ~~~~~~~~~~~~~~~~~
1 warning generated.
```

The variable is only used in the commented out print statement. So,
remove the unused variable, and directly use the value directly in the
print statement.

Change-Id: I3f759f6361ffeb07980cb10e17930e11d738a6a7
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/21463
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Paul Menzel 2017-09-09 11:26:24 +02:00 committed by Felix Held
parent 03f2536f9d
commit 621abec1e8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/southbridge/amd/cimx/sb800/lpc.c
View File

@ -95,15 +95,15 @@ void lpc_enable_childrens_resources(device_t dev)
&& (child->path.type == DEVICE_PATH_PNP)) {
struct resource *res;
for (res = child->resource_list; res; res = res->next) {
u32 base, end; /* don't need long long */
u32 base; /* don't need long long */
if (!(res->flags & IORESOURCE_IO))
continue;
base = res->base;
end = resource_end(res);
/*
printk(BIOS_DEBUG, "sb800 lpc decode:%s,
base=0x%08x, end=0x%08x\n",
dev_path(child), base, end);
dev_path(child), base,
resource_end(res));
*/
switch (base) {
case 0x60: /* KB */