GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/purism/librem*: drop EC chip device 

CB:35086 exposed that the devicetree listed an EC chip for which there
is no actual driver; the EC is entirely ACPI code (.asl) included by
the board's ec.asl. Remove the unnecessary EC chip driver from both
boards, as well as the unnecessary Kconfig selection for librem_bdw.

Test: build/boot Librem 13v1, 13v4, verify battery info etc still correct.

Signed-off-by: Matt DeVillier <matt.devillier@puri.sm>
Change-Id: I5cb0b51881ab8f14e9ec693485f673f4284b5f14
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41788
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Matt DeVillier 2020-05-27 12:23:24 -05:00 committed by Patrick Georgi
parent 2fc0b1c018
commit 6258ec9f70
3 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/purism/librem_bdw/Kconfig
View File

@ -2,7 +2,6 @@ config BOARD_PURISM_BASEBOARD_LIBREM_BDW
def_bool n def_bool n
select SYSTEM_TYPE_LAPTOP select SYSTEM_TYPE_LAPTOP
select BOARD_ROMSIZE_KB_8192 select BOARD_ROMSIZE_KB_8192
select EC_PURISM_LIBREM
select HAVE_ACPI_RESUME select HAVE_ACPI_RESUME
select HAVE_ACPI_TABLES select HAVE_ACPI_TABLES
select INTEL_GMA_HAVE_VBT select INTEL_GMA_HAVE_VBT

6
src/mainboard/purism/librem_bdw/devicetree.cb
View File

@ -52,11 +52,7 @@ chip soc/intel/broadwell
device pci 1c.5 on end # PCIe Port #6 - M.2 NVMe device pci 1c.5 on end # PCIe Port #6 - M.2 NVMe
device pci 1d.0 off end # USB2 EHCI device pci 1d.0 off end # USB2 EHCI
device pci 1e.0 off end # PCI bridge device pci 1e.0 off end # PCI bridge
device pci 1f.0 on device pci 1f.0 on end # LPC bridge
chip ec/purism/librem
device pnp 0c09.0 on end
end
end # LPC bridge
device pci 1f.2 on end # SATA Controller device pci 1f.2 on end # SATA Controller
device pci 1f.3 on end # SMBus device pci 1f.3 on end # SMBus
device pci 1f.6 off end # Thermal device pci 1f.6 off end # Thermal

3
src/mainboard/purism/librem_skl/devicetree.cb
View File

@ -208,9 +208,6 @@ chip soc/intel/skylake
device pci 1d.2 off end # PCI Express Port 11 device pci 1d.2 off end # PCI Express Port 11
device pci 1d.3 off end # PCI Express Port 12 device pci 1d.3 off end # PCI Express Port 12
device pci 1f.0 on device pci 1f.0 on
chip ec/purism/librem
device pnp 0c09.0 on end
end
chip drivers/pc80/tpm chip drivers/pc80/tpm
device pnp 0c31.0 on end device pnp 0c31.0 on end
end end