GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Siemens SiteMP: drop add_mainboard_resources() 

Use of lb_add_memory_region() is reduntant with the MMCONF
resource being set as reserved.

Change-Id: I747ea34823692b6966b2e50d22aea1fb89c73c25
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/1394
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
This commit is contained in:
Kyösti Mälkki 2012-08-02 09:44:03 +03:00 committed by Alexandru Gagniuc
parent 7bdf85bfdb
commit 62673c0290
2 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/siemens/sitemp_g1p1/Kconfig
View File

@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_MP_TABLE select HAVE_MP_TABLE
select HAVE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_MAINBOARD_RESOURCES
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select SB_HT_CHAIN_UNITID_OFFSET_ONLY select SB_HT_CHAIN_UNITID_OFFSET_ONLY
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024

20
src/mainboard/siemens/sitemp_g1p1/mainboard.c
View File

@ -855,26 +855,6 @@ static void enable_dev(device_t dev)
dev->ops->init = init; // rest of mainboard init later dev->ops->init = init; // rest of mainboard init later
} }
/**
* @brief
*
* @param
*/
int add_mainboard_resources(struct lb_memory *mem)
{
device_t dev;
struct resource *res;
dev = dev_find_slot(0, PCI_DEVFN(0,0));
res = probe_resource(dev, 0x1C);
if( res ) {
printk(BIOS_INFO, "mmconf: base=%0llx size=%0llx\n", res->base, res->size);
lb_add_memory_range(mem, LB_MEM_RESERVED, res->base, res->size);
}
return 0;
}
struct chip_operations mainboard_ops = { struct chip_operations mainboard_ops = {
CHIP_NAME(CONFIG_MAINBOARD_PART_NUMBER) CHIP_NAME(CONFIG_MAINBOARD_PART_NUMBER)
.enable_dev = enable_dev, .enable_dev = enable_dev,