ec/starlabs/merlin: Don't store EC values on change

Since CB:62741, the EC values are backed up to the CMOS when entering
S3, S4 and S5. Consequently, they don't need to be stored when they're
changed.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: If0ea392afae4a4d3c605cdea3c5896fbff606215
Reviewed-on: https://review.coreboot.org/c/coreboot/+/62742
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Sean Rhodes 2022-03-10 21:11:15 +00:00 committed by Felix Held
parent fbb46c5438
commit 629f8c5da1
6 changed files with 16 additions and 65 deletions

View File

@ -36,22 +36,8 @@ Method (_Q07, 0, NotSerialized) // Event: Backlight Brightness Up
Method (_Q08, 0, NotSerialized) // Event: Function Lock
{
FLKC = FLKE
Printf ("EC: Function Lock")
}
//
// TODO:
// Below Q Events need to be added
//
// Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock
// {
// TPLC = TPLE
// }
//
// Method (_Q__, 0, NotSerialized) // Event: Keyboard Backlight Brightness
// {
// KLBC = KLBE
// }
//
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode
{

View File

@ -36,20 +36,17 @@ Method (_Q07, 0, NotSerialized) // Event: Backlight Brightness Up
Method (_Q08, 0, NotSerialized) // Event: Function Lock
{
FLKC = FLKE
Printf ("EC: Function Lock")
}
Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock
{
TPLC = TPLE
Printf ("EC: Trackpad Lock")
}
//
// TODO:
// Below Q Events need to be added
//
Method (_Q11) // Event: Keyboard Backlight Brightness
Method (_Q11, 0, NotSerialized) // Event: Keyboard Backlight Brightness
{
KLBC = KLBE
Printf ("EC: Keyboard Brightness")
}
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode

View File

@ -36,23 +36,8 @@ Method (_Q07, 0, NotSerialized) // Event: Backlight Brightness Up
Method (_Q08, 0, NotSerialized) // Event: Function Lock
{
FLKC = FLKE
Printf ("EC: Function Lock")
}
//
// TODO:
// Below Q Events need to be added
//
// Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock
// {
// TPLC = TPLE
// }
//
// Method (_Q__, 0, NotSerialized) // Event: Keyboard Backlight Brightness
// {
// KLBC = KLBE
// }
//
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode
{
^^^^HIDD.HPEM (8)

View File

@ -34,25 +34,10 @@ Method (_Q07, 0, NotSerialized) // Event: Backlight Brightness Up
^^^^HIDD.HPEM (19)
}
Method (_Q08, 0, NotSerialized) // Event: Function Lock
Method (_Q08, 0, NotSerialized) // Event: Function Lock
{
FLKC = FLKE
Printf ("EC: Function Lock")
}
//
// TODO:
// Below Q Events need to be added
//
// Method (_Q04, 0, NotSerialized) // Event: Trackpad Lock
// {
// TPLC = TPLE
// }
//
// Method (_Q__, 0, NotSerialized) // Event: Keyboard Backlight Brightness
// {
// KLBC = KLBE
// KLSC = KLSE
// }
//
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode
{

View File

@ -36,17 +36,16 @@ Method (_Q06) // Event: Backlight Brightness Up
Method (_Q87) // Event: Function Lock
{
FLKC = FLKE
Printf ("EC: Function Lock")
}
Method (_Q88) // Event: Trackpad Lock
{
TPLC = TPLE
Printf ("EC: Trackpad Lock")
}
Method (_Q11) // Event: Keyboard Backlight Brightness
{
KLBC = KLBE
KLSC = KLSE
Printf ("EC: Keyboard Brightness")
}
Method (_Q99) // Event: Airplane Mode

View File

@ -36,17 +36,16 @@ Method (_Q06, 0, NotSerialized) // Event: Backlight Brightness Up
Method (_Q87, 0, NotSerialized) // Event: Function Lock
{
FLKC = FLKE
Printf ("EC: Function Lock")
}
Method (_Q88, 0, NotSerialized) // Event: Trackpad Lock
{
TPLC = TPLE
Printf ("EC: Trackpad Lock")
}
Method (_Q4A) // Event: Keyboard Backlight Brightness
Method (_Q4A, 0, NotSerialized) // Event: Keyboard Backlight Brightness
{
KLSC = KLSE
KLBC = KLBE
Printf ("EC: Keyboard Brightness")
}
Method (_Q99, 0, NotSerialized) // Event: Airplane Mode