GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cycle error in intel southbridges to display GPI status 

Fix obvious mistake in cycle that displays GPI status
I hope i found all duplicates of it.

Change-Id: Ic21ff3ecab85953463e5c23daf808dd5edc82ff8
Signed-off-by: Konstantin Aladyshev <aladyshev@nicevt.ru>
Reviewed-on: http://review.coreboot.org/3435
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Konstantin Aladyshev 2013-03-07 04:04:27 +04:00 committed by Stefan Reinauer
parent 6e5c86ff7d
commit 62f8083dfd
10 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/southbridge/intel/bd82x6x/smi.c
View File

@ -132,7 +132,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");
@ -172,7 +172,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: "); printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i<= 0; i--) { for (i=15; i>= 0; i--) {
if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16)); if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
} }
printk(BIOS_DEBUG, "\n"); printk(BIOS_DEBUG, "\n");

2
src/southbridge/intel/bd82x6x/smihandler.c
View File

@ -166,7 +166,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");

4
src/southbridge/intel/i82801dx/smi.c
View File

@ -136,7 +136,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");
@ -176,7 +176,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: "); printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i<= 0; i--) { for (i=15; i>= 0; i--) {
if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16)); if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
} }
printk(BIOS_DEBUG, "\n"); printk(BIOS_DEBUG, "\n");

2
src/southbridge/intel/i82801dx/smihandler.c
View File

@ -148,7 +148,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");

4
src/southbridge/intel/i82801gx/smi.c
View File

@ -136,7 +136,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");
@ -176,7 +176,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: "); printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i<= 0; i--) { for (i=15; i>= 0; i--) {
if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16)); if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
} }
printk(BIOS_DEBUG, "\n"); printk(BIOS_DEBUG, "\n");

2
src/southbridge/intel/i82801gx/smihandler.c
View File

@ -143,7 +143,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");

4
src/southbridge/intel/i82801ix/smi.c
View File

@ -140,7 +140,7 @@ static void dump_gpe0_status(u64 gpe0_sts)
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
if (gpe0_sts & (1LL << 32)) printk(BIOS_DEBUG, "USB6 "); if (gpe0_sts & (1LL << 32)) printk(BIOS_DEBUG, "USB6 ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");
@ -181,7 +181,7 @@ static void dump_alt_gp_smi_status(u16 alt_gp_smi_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "ALT_GP_SMI_STS: "); printk(BIOS_DEBUG, "ALT_GP_SMI_STS: ");
for (i=15; i<= 0; i--) { for (i=15; i>= 0; i--) {
if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16)); if (alt_gp_smi_sts & (1 << i)) printk(BIOS_DEBUG, "GPI%d ", (i-16));
} }
printk(BIOS_DEBUG, "\n"); printk(BIOS_DEBUG, "\n");

2
src/southbridge/intel/i82801ix/smihandler.c
View File

@ -137,7 +137,7 @@ static void dump_gpe0_status(u64 gpe0_sts)
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
if (gpe0_sts & (1LL << 32)) printk(BIOS_DEBUG, "USB6 "); if (gpe0_sts & (1LL << 32)) printk(BIOS_DEBUG, "USB6 ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");

2
src/southbridge/intel/sch/smi.c
View File

@ -168,7 +168,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");

2
src/southbridge/intel/sch/smihandler.c
View File

@ -169,7 +169,7 @@ static void dump_gpe0_status(u32 gpe0_sts)
{ {
int i; int i;
printk(BIOS_DEBUG, "GPE0_STS: "); printk(BIOS_DEBUG, "GPE0_STS: ");
for (i=31; i<= 16; i--) { for (i=31; i>= 16; i--) {
if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16)); if (gpe0_sts & (1 << i)) printk(BIOS_DEBUG, "GPIO%d ", (i-16));
} }
if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 "); if (gpe0_sts & (1 << 14)) printk(BIOS_DEBUG, "USB4 ");