GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake: Correct the logic for the legacy 8254 timer 

The `use_8254` should be flipped, the same as the other Intel
SOCs.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I2d6c859c0910b796d2ae5874a560ff9974578106
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Sean Rhodes 2023-08-23 12:43:38 +01:00 committed by Felix Held
parent 2cd2263c32
commit 6319ef9718
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/intel/apollolake/chip.c
View File

@ -749,7 +749,7 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd)
/* 8254 Timer */ /* 8254 Timer */
bool use_8254 = get_uint_option("legacy_8254_timer", CONFIG(USE_LEGACY_8254_TIMER)); bool use_8254 = get_uint_option("legacy_8254_timer", CONFIG(USE_LEGACY_8254_TIMER));
silconfig->Timer8254ClkSetting = use_8254; silconfig->Timer8254ClkSetting = !use_8254;
/* FSP should let coreboot set subsystem IDs, which are read/write-once */ /* FSP should let coreboot set subsystem IDs, which are read/write-once */
silconfig->SubSystemVendorId = 0; silconfig->SubSystemVendorId = 0;