From 6337180ba90c5a2a8b986bf7837cb05ed68b2647 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 3 Mar 2023 14:17:00 -0600 Subject: [PATCH] mb/google/skyrim: Enable L1 ASPM substates for PCIe devices Enable both L1.1 and L1.2 substates for the WiFi, SD card reader, and SSD (both NVMe and eMMC). If a given device does not support a particular substate, then it will not be enabled during PCIe enumeration by coreboot. BUG=b:270690572 TEST=build/boot multiple skyrim/whiterun/frostflow SKUs with different storage configs, verify WiFi/SD card/SSD all functional and have L1 substates enabled insofar as they are supported by the device. BRANCH=skyrim Change-Id: Ib84df8b9d97282ae696414e52c4a65cfb0a81194 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/73438 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth Reviewed-by: Jon Murphy --- src/mainboard/google/skyrim/port_descriptors.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mainboard/google/skyrim/port_descriptors.c b/src/mainboard/google/skyrim/port_descriptors.c index 067b656065..3e754916e7 100644 --- a/src/mainboard/google/skyrim/port_descriptors.c +++ b/src/mainboard/google/skyrim/port_descriptors.c @@ -20,6 +20,8 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .turn_off_unused_lanes = true, .link_aspm = ASPM_L1, .link_hotplug = 3, + .link_aspm_L1_1 = true, + .link_aspm_L1_2 = true, .clk_req = CLK_REQ2, }, { /* SD */ @@ -33,6 +35,8 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .turn_off_unused_lanes = true, .link_aspm = ASPM_L1, .link_hotplug = 3, + .link_aspm_L1_1 = true, + .link_aspm_L1_2 = true, .gpio_group_id = GPIO_27, .clk_req = CLK_REQ1, }, @@ -47,6 +51,8 @@ static const fsp_dxio_descriptor skyrim_mdn_dxio_descriptors[] = { .turn_off_unused_lanes = true, .link_aspm = ASPM_L1, .link_hotplug = 3, + .link_aspm_L1_1 = true, + .link_aspm_L1_2 = true, .gpio_group_id = GPIO_6, .clk_req = CLK_REQ0, },