{cpu,soc}/intel: remove unused smm_init() function
There used to be a need for an empty smm_init() function because initialize_cpus() called it even though nothing called initialize_cpus(). However, garbage collection at link time is implemented so there's no reason to provide an empty function to satisfy a symbol that is completely culled during link. Remove it. Change-Id: Ic13c85f1d3d57e38e7132e4289a98a95829f765a Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/14605 Tested-by: build bot (Jenkins) Reviewed-by: Duncan Laurie <dlaurie@google.com> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
parent
770d7c7395
commit
6366d92803
|
@ -352,15 +352,6 @@ void smm_relocate(void)
|
|||
smm_initiate_relocation();
|
||||
}
|
||||
|
||||
void smm_init(void)
|
||||
{
|
||||
/* smm_init() is normally called from initialize_cpus() in
|
||||
* lapic_cpu_init.c. However, that path is no longer used. Don't reuse
|
||||
* the function name because that would cause confusion.
|
||||
* The smm_initialize() function above is used to setup SMM at the
|
||||
* appropriate time. */
|
||||
}
|
||||
|
||||
void smm_lock(void)
|
||||
{
|
||||
/* LOCK the SMM memory window and enable normal SMM.
|
||||
|
|
|
@ -17,8 +17,5 @@
|
|||
#include <device/pci_rom.h>
|
||||
#include <soc/acpi.h>
|
||||
|
||||
|
||||
void smm_init(void) {}
|
||||
|
||||
/* Rmodules don't like weak symbols. */
|
||||
u32 map_oprom_vendev(u32 vendev) { return vendev; }
|
||||
|
|
|
@ -29,10 +29,6 @@
|
|||
/* Save settings which will be committed in SMI functions. */
|
||||
static uint32_t smm_save_params[SMM_SAVE_PARAM_COUNT];
|
||||
|
||||
void smm_init(void)
|
||||
{
|
||||
}
|
||||
|
||||
void southcluster_smm_save_param(int param, uint32_t data)
|
||||
{
|
||||
smm_save_params[param] = data;
|
||||
|
|
|
@ -316,15 +316,6 @@ void smm_relocate(void)
|
|||
smm_initiate_relocation();
|
||||
}
|
||||
|
||||
void smm_init(void)
|
||||
{
|
||||
/* smm_init() is normally called from initialize_cpus() in
|
||||
* lapic_cpu_init.c. However, that path is no longer used. Don't reuse
|
||||
* the function name because that would cause confusion.
|
||||
* The smm_initialize() function above is used to setup SMM at the
|
||||
* appropriate time. */
|
||||
}
|
||||
|
||||
void smm_lock(void)
|
||||
{
|
||||
/* LOCK the SMM memory window and enable normal SMM.
|
||||
|
|
|
@ -20,9 +20,5 @@
|
|||
|
||||
void acpi_create_serialio_ssdt(acpi_header_t *ssdt) {}
|
||||
|
||||
#if IS_ENABLED(CONFIG_HAVE_SMI_HANDLER)
|
||||
void smm_init(void) {}
|
||||
#endif
|
||||
|
||||
/* Rmodules don't like weak symbols. */
|
||||
u32 map_oprom_vendev(u32 vendev) { return vendev; }
|
||||
|
|
|
@ -305,17 +305,6 @@ void smm_relocate(void)
|
|||
smm_initiate_relocation();
|
||||
}
|
||||
|
||||
void smm_init(void)
|
||||
{
|
||||
/*
|
||||
* smm_init() is normally called from initialize_cpus() in
|
||||
* lapic_cpu_init.c. However, that path is no longer used. Don't reuse
|
||||
* the function name because that would cause confusion.
|
||||
* The smm_initialize() function above is used to setup SMM at the
|
||||
* appropriate time.
|
||||
*/
|
||||
}
|
||||
|
||||
void smm_lock(void)
|
||||
{
|
||||
/*
|
||||
|
|
Loading…
Reference in New Issue