GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel: Get rid of smm_get_pmbase 

Change-Id: I2b3168c600a81502f9cd1ff3203c492cf026e532
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/27279
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Patrick Rudolph 2018-06-28 14:29:49 +02:00 committed by Patrick Rudolph
parent 5132570845
commit 63952e1060
5 changed files with 7 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/include/cpu/x86/smm.h
View File

@ -507,9 +507,6 @@ void smi_release_lock(void);
extern unsigned char _binary_smm_start[];
extern unsigned char _binary_smm_end[];
/* Get PMBASE address */
u16 smm_get_pmbase(void);
struct smm_runtime {
u32 smbase;
u32 save_state_size;

6
src/southbridge/intel/common/smihandler.c
View File

@ -35,12 +35,6 @@ u16 get_pmbase(void)
return lpc_get_pmbase();
}
/* Defined in <cpu/x86/smm.h> which is used outside of common code*/
u16 smm_get_pmbase(void)
{
return lpc_get_pmbase();
}
void gpi_route_interrupt(u8 gpi, u8 mode)
{
u32 gpi_rout;

8
src/southbridge/intel/fsp_bd82x6x/smihandler.c
View File

@ -23,6 +23,8 @@
#include <elog.h>
#include <halt.h>
#include <pc80/mc146818rtc.h>
#include <southbridge/intel/common/pmbase.h>
#include "pch.h"
#include "nvs.h"
@ -37,10 +39,6 @@
* initialize it with a sane value
*/
static u16 pmbase = DEFAULT_PMBASE;
u16 smm_get_pmbase(void)
{
return pmbase;
}
static u8 smm_initialized = 0;
@ -729,7 +727,7 @@ void southbridge_smi_handler(void)
u32 smi_sts;
/* Update global variable pmbase */
pmbase = pci_read_config16(PCI_DEV(0, 0x1f, 0), 0x40) & 0xfffc;
pmbase = lpc_get_pmbase();
/* We need to clear the SMI status registers, or we won't see what's
* happening in the following calls.

7
src/southbridge/intel/fsp_i89xx/smihandler.c
View File

@ -23,6 +23,7 @@
#include <elog.h>
#include <halt.h>
#include <pc80/mc146818rtc.h>
#include <southbridge/intel/common/pmbase.h>
#include "pch.h"
#include "nvs.h"
@ -37,10 +38,6 @@
* initialize it with a sane value
*/
static u16 pmbase = DEFAULT_PMBASE;
u16 smm_get_pmbase(void)
{
return pmbase;
}
static u8 smm_initialized = 0;
@ -726,7 +723,7 @@ void southbridge_smi_handler(void)
u32 smi_sts;
/* Update global variable pmbase */
pmbase = pci_read_config16(PCI_DEV(0, 0x1f, 0), 0x40) & 0xfffc;
pmbase = lpc_get_pmbase();
/* We need to clear the SMI status registers, or we won't see what's
* happening in the following calls.

7
src/southbridge/intel/ibexpeak/smihandler.c
View File

@ -23,6 +23,7 @@
#include <elog.h>
#include <halt.h>
#include <pc80/mc146818rtc.h>
#include <southbridge/intel/common/pmbase.h>
#include "pch.h"
#include "nvs.h"
@ -39,10 +40,6 @@
* initialize it with a sane value
*/
static u16 pmbase = DEFAULT_PMBASE;
u16 smm_get_pmbase(void)
{
return pmbase;
}
static u8 smm_initialized = 0;
@ -829,7 +826,7 @@ void southbridge_smi_handler(void)
u32 smi_sts;
/* Update global variable pmbase */
pmbase = pci_read_config16(PCI_DEV(0, 0x1f, 0), 0x40) & 0xfffc;
pmbase = lpc_get_pmbase();
/* We need to clear the SMI status registers, or we won't see what's
* happening in the following calls.