intel: Get rid of smm_get_pmbase
Change-Id: I2b3168c600a81502f9cd1ff3203c492cf026e532 Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Reviewed-on: https://review.coreboot.org/27279 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
parent
5132570845
commit
63952e1060
|
@ -507,9 +507,6 @@ void smi_release_lock(void);
|
||||||
extern unsigned char _binary_smm_start[];
|
extern unsigned char _binary_smm_start[];
|
||||||
extern unsigned char _binary_smm_end[];
|
extern unsigned char _binary_smm_end[];
|
||||||
|
|
||||||
/* Get PMBASE address */
|
|
||||||
u16 smm_get_pmbase(void);
|
|
||||||
|
|
||||||
struct smm_runtime {
|
struct smm_runtime {
|
||||||
u32 smbase;
|
u32 smbase;
|
||||||
u32 save_state_size;
|
u32 save_state_size;
|
||||||
|
|
|
@ -35,12 +35,6 @@ u16 get_pmbase(void)
|
||||||
return lpc_get_pmbase();
|
return lpc_get_pmbase();
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Defined in <cpu/x86/smm.h> which is used outside of common code*/
|
|
||||||
u16 smm_get_pmbase(void)
|
|
||||||
{
|
|
||||||
return lpc_get_pmbase();
|
|
||||||
}
|
|
||||||
|
|
||||||
void gpi_route_interrupt(u8 gpi, u8 mode)
|
void gpi_route_interrupt(u8 gpi, u8 mode)
|
||||||
{
|
{
|
||||||
u32 gpi_rout;
|
u32 gpi_rout;
|
||||||
|
|
|
@ -23,6 +23,8 @@
|
||||||
#include <elog.h>
|
#include <elog.h>
|
||||||
#include <halt.h>
|
#include <halt.h>
|
||||||
#include <pc80/mc146818rtc.h>
|
#include <pc80/mc146818rtc.h>
|
||||||
|
#include <southbridge/intel/common/pmbase.h>
|
||||||
|
|
||||||
#include "pch.h"
|
#include "pch.h"
|
||||||
|
|
||||||
#include "nvs.h"
|
#include "nvs.h"
|
||||||
|
@ -37,10 +39,6 @@
|
||||||
* initialize it with a sane value
|
* initialize it with a sane value
|
||||||
*/
|
*/
|
||||||
static u16 pmbase = DEFAULT_PMBASE;
|
static u16 pmbase = DEFAULT_PMBASE;
|
||||||
u16 smm_get_pmbase(void)
|
|
||||||
{
|
|
||||||
return pmbase;
|
|
||||||
}
|
|
||||||
|
|
||||||
static u8 smm_initialized = 0;
|
static u8 smm_initialized = 0;
|
||||||
|
|
||||||
|
@ -729,7 +727,7 @@ void southbridge_smi_handler(void)
|
||||||
u32 smi_sts;
|
u32 smi_sts;
|
||||||
|
|
||||||
/* Update global variable pmbase */
|
/* Update global variable pmbase */
|
||||||
pmbase = pci_read_config16(PCI_DEV(0, 0x1f, 0), 0x40) & 0xfffc;
|
pmbase = lpc_get_pmbase();
|
||||||
|
|
||||||
/* We need to clear the SMI status registers, or we won't see what's
|
/* We need to clear the SMI status registers, or we won't see what's
|
||||||
* happening in the following calls.
|
* happening in the following calls.
|
||||||
|
|
|
@ -23,6 +23,7 @@
|
||||||
#include <elog.h>
|
#include <elog.h>
|
||||||
#include <halt.h>
|
#include <halt.h>
|
||||||
#include <pc80/mc146818rtc.h>
|
#include <pc80/mc146818rtc.h>
|
||||||
|
#include <southbridge/intel/common/pmbase.h>
|
||||||
#include "pch.h"
|
#include "pch.h"
|
||||||
|
|
||||||
#include "nvs.h"
|
#include "nvs.h"
|
||||||
|
@ -37,10 +38,6 @@
|
||||||
* initialize it with a sane value
|
* initialize it with a sane value
|
||||||
*/
|
*/
|
||||||
static u16 pmbase = DEFAULT_PMBASE;
|
static u16 pmbase = DEFAULT_PMBASE;
|
||||||
u16 smm_get_pmbase(void)
|
|
||||||
{
|
|
||||||
return pmbase;
|
|
||||||
}
|
|
||||||
|
|
||||||
static u8 smm_initialized = 0;
|
static u8 smm_initialized = 0;
|
||||||
|
|
||||||
|
@ -726,7 +723,7 @@ void southbridge_smi_handler(void)
|
||||||
u32 smi_sts;
|
u32 smi_sts;
|
||||||
|
|
||||||
/* Update global variable pmbase */
|
/* Update global variable pmbase */
|
||||||
pmbase = pci_read_config16(PCI_DEV(0, 0x1f, 0), 0x40) & 0xfffc;
|
pmbase = lpc_get_pmbase();
|
||||||
|
|
||||||
/* We need to clear the SMI status registers, or we won't see what's
|
/* We need to clear the SMI status registers, or we won't see what's
|
||||||
* happening in the following calls.
|
* happening in the following calls.
|
||||||
|
|
|
@ -23,6 +23,7 @@
|
||||||
#include <elog.h>
|
#include <elog.h>
|
||||||
#include <halt.h>
|
#include <halt.h>
|
||||||
#include <pc80/mc146818rtc.h>
|
#include <pc80/mc146818rtc.h>
|
||||||
|
#include <southbridge/intel/common/pmbase.h>
|
||||||
#include "pch.h"
|
#include "pch.h"
|
||||||
|
|
||||||
#include "nvs.h"
|
#include "nvs.h"
|
||||||
|
@ -39,10 +40,6 @@
|
||||||
* initialize it with a sane value
|
* initialize it with a sane value
|
||||||
*/
|
*/
|
||||||
static u16 pmbase = DEFAULT_PMBASE;
|
static u16 pmbase = DEFAULT_PMBASE;
|
||||||
u16 smm_get_pmbase(void)
|
|
||||||
{
|
|
||||||
return pmbase;
|
|
||||||
}
|
|
||||||
|
|
||||||
static u8 smm_initialized = 0;
|
static u8 smm_initialized = 0;
|
||||||
|
|
||||||
|
@ -829,7 +826,7 @@ void southbridge_smi_handler(void)
|
||||||
u32 smi_sts;
|
u32 smi_sts;
|
||||||
|
|
||||||
/* Update global variable pmbase */
|
/* Update global variable pmbase */
|
||||||
pmbase = pci_read_config16(PCI_DEV(0, 0x1f, 0), 0x40) & 0xfffc;
|
pmbase = lpc_get_pmbase();
|
||||||
|
|
||||||
/* We need to clear the SMI status registers, or we won't see what's
|
/* We need to clear the SMI status registers, or we won't see what's
|
||||||
* happening in the following calls.
|
* happening in the following calls.
|
||||||
|
|
Loading…
Reference in New Issue