From 63df43d7154b38d1baebf5a88645b4175e029efa Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Sat, 11 Sep 2021 08:17:39 +0200 Subject: [PATCH] mb/prodrive/hermes: Hook up P2SB and PMC in devicetree Fixes commit bd5b4aa683a634a73a6a63d1f197e2bb74b6a80e "soc/intel/cannonlake: Switch PMC to use device callbacks" as it requires the PCI device 1f.2 to be present in the devicetree. It was missing for this mainboard and caused a boot failure. Change-Id: Iaf508b2d955578efa2a266af50c568f5c0a47aaf Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/57574 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Arthur Heymans --- src/mainboard/prodrive/hermes/devicetree.cb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index b7e89dc537..cafc81e6ba 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb @@ -38,9 +38,11 @@ chip soc/intel/cannonlake end # AST2500, but not enabled to decode LPC cycles end - device pci 1f.3 on end - device pci 1f.4 on end # SMBus - device pci 1f.5 on end # PCH SPI + device pci 1f.1 on end # P2SB + device pci 1f.2 hidden end # Power Management Controller + device pci 1f.3 on end # Intel HDA + device pci 1f.4 on end # SMBus + device pci 1f.5 on end # PCH SPI end end