lib/timestamp: Do not initialize cache in timestamp_cache_get()
timestamp_cache_get() would call timestamp_cache_init() whenever it found a timestamp cache in the TIMESTAMP_CACHE_UNINITIALIZED state. That means that timestamp_cache_get() will never reurn a cache in the uninitialized state. However, timestamp_init() checks against the uninitialized state, as it does not expect timestamp_cache_get() to perform any initialization. As a result, the conditional branch can never be reached. Simply remove the timestamp_cache_init() call from timestamp_cache_get(). Change-Id: I573ffbf948b69948a3b383fa3bc94382f205b8f8 Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc@intel.com> Reviewed-on: https://review.coreboot.org/14861 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
parent
87c6097c8f
commit
63e7b5b8a7
|
@ -86,9 +86,6 @@ static struct timestamp_cache *timestamp_cache_get(void)
|
|||
ts_cache = car_get_var_ptr((void *)_timestamp);
|
||||
}
|
||||
|
||||
if (ts_cache && ts_cache->cache_state == TIMESTAMP_CACHE_UNINITIALIZED)
|
||||
timestamp_cache_init(ts_cache, 0);
|
||||
|
||||
return ts_cache;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue