GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/braswell: Fix spacing issues detected by checkpatch 

Fix the following errors and warnings detected by checkpatch.pl:

ERROR: space required after that ',' (ctx:VxV)
ERROR: space prohibited before that ',' (ctx:WxE)
ERROR: spaces required around that '=' (ctx:WxV)
ERROR: code indent should use tabs where possible
WARNING: space prohibited between function name and open parenthesis '('
WARNING: please, no spaces at the start of a line

TEST=Build for cyan

Change-Id: I84d4204585b498b695608c5008fdfb7961e2416f
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18869
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Tested-by: build bot (Jenkins)
This commit is contained in:
Lee Leahy 2017-03-16 17:30:09 -07:00
parent f4c4ab9826
commit 6598b91fe3
5 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/braswell/acpi.c
View File

@ -498,7 +498,7 @@ unsigned long southcluster_write_acpi_tables(device_t device,
if (ssdt2->length) {
current += ssdt2->length;
acpi_add_table(rsdp, ssdt2);
printk(BIOS_DEBUG, "ACPI: * SSDT2 @ %p Length %x\n",ssdt2,
printk(BIOS_DEBUG, "ACPI: * SSDT2 @ %p Length %x\n", ssdt2,
ssdt2->length);
current = acpi_align_current(current);
} else {
@ -517,7 +517,7 @@ void southcluster_inject_dsdt(device_t device)
gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS);
if (!gnvs) {
gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof (*gnvs));
gnvs = cbmem_add(CBMEM_ID_ACPI_GNVS, sizeof(*gnvs));
if (gnvs)
memset(gnvs, 0, sizeof(*gnvs));
}

12
src/soc/intel/braswell/chip.h
View File

@ -34,8 +34,8 @@
#define MEM_LPDDR3 1
enum lpe_clk_src {
LPE_CLK_SRC_XTAL,
LPE_CLK_SRC_PLL,
LPE_CLK_SRC_XTAL,
LPE_CLK_SRC_PLL,
};
enum usb_comp_bg_value {
@ -74,10 +74,10 @@ struct soc_intel_braswell_config {
int pcie_wake_enable;
/* Program USB2_COMPBG register.
* [10:7] - select vref to AFE port
* x111 - 575mV, x110 - 650mV, x101 - 550mV, x100 - 537.5mV,
* x011 - 625mV, x010 - 700mV, x001 - 600mV, x000 - 675mV
*/
* [10:7] - select vref to AFE port
* x111 - 575mV, x110 - 650mV, x101 - 550mV, x100 - 537.5mV,
* x011 - 625mV, x010 - 700mV, x001 - 600mV, x000 - 675mV
*/
enum usb_comp_bg_value usb_comp_bg;

6
src/soc/intel/braswell/gpio.c
View File

@ -59,9 +59,9 @@ static const u8 gpecommunity_gpio_to_pad[GP_EAST_COUNT] = {
/* GPIO Community descriptions */
static const struct gpio_bank gpnorth_community = {
.gpio_count = GP_NORTH_COUNT,
.gpio_to_pad = gpncommunity_gpio_to_pad ,
.pad_base = COMMUNITY_GPNORTH_BASE ,
.has_gpe_en = GPE_CAPABLE ,
.gpio_to_pad = gpncommunity_gpio_to_pad,
.pad_base = COMMUNITY_GPNORTH_BASE,
.has_gpe_en = GPE_CAPABLE,
.has_wake_en = 1,
};

4
src/soc/intel/braswell/gpio_support.c
View File

@ -103,7 +103,7 @@ static int gpio_get_community_num(gpio_t gpio_num, int *pad)
static void gpio_config_pad(gpio_t gpio_num, const struct soc_gpio_map *cfg)
{
int comm = 0;
int pad_num =0;
int pad_num = 0;
uint32_t *pad_config0_reg;
uint32_t *pad_config1_reg;
int max_gpio_cnt = GP_SOUTHWEST_COUNT + GP_NORTH_COUNT + GP_EAST_COUNT
@ -143,7 +143,7 @@ void gpio_input(gpio_t gpio_num)
int gpio_get(gpio_t gpio_num)
{
int comm = 0;
int pad_num =0;
int pad_num = 0;
uint32_t *pad_config0_reg;
u32 pad_value;
int max_gpio_cnt = GP_SOUTHWEST_COUNT + GP_NORTH_COUNT + GP_EAST_COUNT

2
src/soc/intel/braswell/include/soc/gpio.h
View File

@ -315,7 +315,7 @@
| PAD_GPIO_ENABLE | PAD_GPIOFG_GPI \
| PAD_INT_SEL(int_sel), \
.pad_conf1 = PAD_TRIG_EDGE_LOW | PAD_CONFIG1_DEFAULT0, \
.int_mask = 1 ,\
.int_mask = 1,\
.wake_mask = 1 }
#define GPIO_SMI(int_sel) \