vpd: decode calibration data into binary

The preferred way of communicating WiFi calibration data to the kernel
is binary blob. But this data is stored in the VPD, and must be in
ASCII, so it is encoded using base64.

With the recent addition of the bas64 decoder it is possible to
convert the VPD representation to the form preferred by the kernel.

BRANCH=none
BUG=chromium:450169
TEST=with the rest of the patches applied verified that on both storm
     and urara the device tree contains the required binary data.

Change-Id: I89da94bb425767eedc5e2d576e507663afad65ed
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: c2ae38ded24394e0640b5d077e2231cf956397c5
Original-Change-Id: If8a7d0883ea8bb21a13bf203b25ee9f8a08903a9
Original-Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/262842
Reviewed-on: http://review.coreboot.org/9895
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Vadim Bendebury 2015-03-28 22:13:29 -07:00 committed by Patrick Georgi
parent 11ecdb7537
commit 65f08d50ae
1 changed files with 25 additions and 3 deletions

View File

@ -17,6 +17,7 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include <b64_decode.h>
#include <cbmem.h> #include <cbmem.h>
#include <console/console.h> #include <console/console.h>
#include <string.h> #include <string.h>
@ -71,7 +72,7 @@ struct calibration_entry {
struct vpd_blob_cache_t { struct vpd_blob_cache_t {
/* The longest name template must fit with an extra character. */ /* The longest name template must fit with an extra character. */
char key_name[40]; char key_name[40];
const void *value_pointer; void *value_pointer;
unsigned blob_size; unsigned blob_size;
unsigned key_size; unsigned key_size;
unsigned value_size; unsigned value_size;
@ -108,7 +109,9 @@ static size_t fill_up_entries_cache(struct vpd_blob_cache_t *cache,
for (j = 0; j < MAX_WIFI_INTERFACE_COUNT; j++) { for (j = 0; j < MAX_WIFI_INTERFACE_COUNT; j++) {
const void *payload; const void *payload;
void *decoded_payload;
int payload_size; int payload_size;
size_t decoded_size;
strcpy(cache->key_name, templates[i]); strcpy(cache->key_name, templates[i]);
cache->key_name[index_location] = j + '0'; cache->key_name[index_location] = j + '0';
@ -117,9 +120,27 @@ static size_t fill_up_entries_cache(struct vpd_blob_cache_t *cache,
if (!payload) if (!payload)
continue; continue;
cache->value_pointer = payload; decoded_size = B64_DECODED_SIZE(payload_size);
decoded_payload = malloc(decoded_size);
if (!decoded_payload) {
printk(BIOS_ERR,
"%s: failed allocating %zd bytes\n",
__func__, decoded_size);
continue;
}
decoded_size = b64_decode(payload, payload_size,
decoded_payload);
if (!decoded_size) {
free(decoded_payload);
printk(BIOS_ERR, "%s: failed decoding %s\n",
__func__, cache->key_name);
continue;
}
cache->value_pointer = decoded_payload;
cache->key_size = key_length; cache->key_size = key_length;
cache->value_size = payload_size; cache->value_size = decoded_size;
cache->blob_size = cache->blob_size =
ALIGN(sizeof(struct calibration_blob) + ALIGN(sizeof(struct calibration_blob) +
cache->key_size + cache->key_size +
@ -187,6 +208,7 @@ void cbmem_add_vpd_calibration_data(void)
/* and the value */ /* and the value */
pointer += cache->key_size; pointer += cache->key_size;
memcpy(pointer, cache->value_pointer, cache->value_size); memcpy(pointer, cache->value_pointer, cache->value_size);
free(cache->value_pointer);
printk(BIOS_INFO, "%s: added %s to CBMEM\n", printk(BIOS_INFO, "%s: added %s to CBMEM\n",
__func__, cache->key_name); __func__, cache->key_name);