From 663efbb0f74aa375e9c96a7ac433082d3a4f6f43 Mon Sep 17 00:00:00 2001 From: Harsha B R Date: Tue, 7 Feb 2023 16:22:11 +0530 Subject: [PATCH] mb/intel/mtlrvp: Enable PCIE Advanced Error Reporting This patch enables PCI Express Advanced Error Reporting Capability for WWAN, WLAN, and SSD root ports. On enabling PCIE_RP_AER, PCIE device will automatically report (if any error) about the error nature to the corresponding PCIe root port. BUG=b:224325352 BRANCH=None TEST=Build and boot mtlrvp to ChromeOS. Signed-off-by: Harsha B R Change-Id: Iab8619818e2219b41287b895513eb04b0464401e Reviewed-on: https://review.coreboot.org/c/coreboot/+/72874 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Jamie Ryu Reviewed-by: Sridhar Siricilla --- .../mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb index 57f9f3da15..17b9ed8e3c 100644 --- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb @@ -150,7 +150,7 @@ chip soc/intel/meteorlake register "pcie_rp[PCIE_RP(7)]" = "{ .clk_src = 1, .clk_req = 1, - .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR, + .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER, }" chip soc/intel/common/block/pcie/rtd3 register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C05)" @@ -175,7 +175,7 @@ chip soc/intel/meteorlake register "pcie_rp[PCIE_RP(8)]" = "{ .clk_src = 5, .clk_req = 5, - .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR, + .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER, }" end # WLAN device ref pcie_rp10 on @@ -183,7 +183,7 @@ chip soc/intel/meteorlake register "pcie_rp[PCIE_RP(10)]" = "{ .clk_src = 8, .clk_req = 8, - .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR, + .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER, }" end # PCIE10 SSD Gen4 device ref pcie_rp11 on @@ -191,7 +191,7 @@ chip soc/intel/meteorlake register "pcie_rp[PCIE_RP(11)]" = "{ .clk_src = 7, .clk_req = 7, - .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR, + .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER, }" end # PCIE11 SSD Gen4 device ref xhci on