GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/ironlake: Add more host bridge PCI IDs 

The host bridge PCI device ID can be changed by the firmware. There
is no documentation about it, though. There's 'official' IDs, which
appear in spec updates and Windows drivers, and 'mysterious' IDs,
which Intel doesn't want OSes to know about and thus are not listed.

The current coreboot code seems to be able to change the device ID
of the host bridge, but it seems to be missing a warm reset so that
the device ID changes. Account for the 'mysterious' device IDs in
the northbridge driver, so that booting an OS has a chance to work.

For the sake of completeness, add the PCI device IDs for Clarkdale.
Although only Arrandale is known to work, both of them are Ironlake.

It is possible that the Management Engine handles changing the PCI
device ID, which would not happen when using a broken ME firmware.

Change-Id: I93c9c47e2b0bf13d80c986c7d66b6cdf0e192b22
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45562
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2020-09-21 21:03:46 +02:00
parent 9d7431c848
commit 6642b44b29
1 changed files with 28 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/northbridge/intel/ironlake/northbridge.c
View File

@ -202,10 +202,34 @@ static struct device_operations mc_ops = {
.ops_pci = &pci_dev_ops_pci,
};
static const struct pci_driver mc_driver_ard __pci_driver = {
/*
* The host bridge PCI device ID can be changed by the firmware. There
* is no documentation about it, though. There's 'official' IDs, which
* appear in spec updates and Windows drivers, and 'mysterious' IDs,
* which Intel doesn't want OSes to know about and thus are not listed.
*
* The current coreboot code seems to be able to change the device ID
* of the host bridge, but it seems to be missing a warm reset so that
* the device ID changes. Account for the 'mysterious' device IDs in
* the northbridge driver, so that booting an OS has a chance to work.
*/
static const unsigned short pci_device_ids[] = {
/* 'Official' DIDs */
0x0040, /* Clarkdale */
0x0044, /* Arrandale */
0x0048, /* Unknown, but it appears in OS drivers and raminit */
/* Mysterious DIDs, taken from Linux' intel-agp driver */
0x0062, /* Arrandale A-? */
0x0069, /* Clarkdale K-0 */
0x006a, /* Arrandale K-0 */
0
};
static const struct pci_driver mc_driver_ilk __pci_driver = {
.ops = &mc_ops,
.vendor = PCI_VENDOR_ID_INTEL,
.device = 0x0044, /* Arrandale DRAM controller */
.devices = pci_device_ids,
};
static struct device_operations cpu_bus_ops = {