soc/intel/broadwell: Drop helper functions

Done for consistency with Haswell in order to ease unification.

Change-Id: I445f086cfcb65a6001ced3326fb9f25a4188b888
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55527
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2021-06-15 13:46:26 +02:00 committed by Paul Fagerburg
parent 863efe4545
commit 6672dff088
3 changed files with 8 additions and 19 deletions

View File

@ -7,6 +7,7 @@
#include <cpu/intel/haswell/haswell.h> #include <cpu/intel/haswell/haswell.h>
#include <device/pci_ops.h> #include <device/pci_ops.h>
#include <console/console.h> #include <console/console.h>
#include <device/device.h>
#include <types.h> #include <types.h>
#include <cpu/x86/msr.h> #include <cpu/x86/msr.h>
#include <cpu/intel/turbo.h> #include <cpu/intel/turbo.h>
@ -69,8 +70,13 @@ static unsigned long acpi_fill_dmar(unsigned long current)
if (emit_igd) { if (emit_igd) {
const unsigned long tmp = current; const unsigned long tmp = current;
current += acpi_create_dmar_rmrr(current, 0, const struct device *sa_dev = pcidev_on_root(0, 0);
sa_get_gsm_base(), sa_get_tolud_base() - 1);
/* Bit 0 is lock bit, not part of address */
const u32 tolud = pci_read_config32(sa_dev, TOLUD) & ~1;
const u32 bgsm = pci_read_config32(sa_dev, BGSM) & ~1;
current += acpi_create_dmar_rmrr(current, 0, bgsm, tolud - 1);
current += acpi_create_dmar_ds_pci(current, 0, 2, 0); current += acpi_create_dmar_ds_pci(current, 0, 2, 0);
acpi_dmar_rmrr_fixup(tmp, current); acpi_dmar_rmrr_fixup(tmp, current);
} }

View File

@ -135,7 +135,4 @@
/* System Agent identification */ /* System Agent identification */
u8 systemagent_revision(void); u8 systemagent_revision(void);
uintptr_t sa_get_tolud_base(void);
uintptr_t sa_get_gsm_base(void);
#endif #endif

View File

@ -21,20 +21,6 @@ u8 systemagent_revision(void)
return pci_read_config8(sa_dev, PCI_REVISION_ID); return pci_read_config8(sa_dev, PCI_REVISION_ID);
} }
uintptr_t sa_get_tolud_base(void)
{
struct device *sa_dev = pcidev_path_on_root(SA_DEVFN_ROOT);
/* Bit 0 is lock bit, not part of address */
return pci_read_config32(sa_dev, TOLUD) & ~1;
}
uintptr_t sa_get_gsm_base(void)
{
struct device *sa_dev = pcidev_path_on_root(SA_DEVFN_ROOT);
/* Bit 0 is lock bit, not part of address */
return pci_read_config32(sa_dev, BGSM) & ~1;
}
static int get_pcie_bar(struct device *dev, unsigned int index, u32 *base, static int get_pcie_bar(struct device *dev, unsigned int index, u32 *base,
u32 *len) u32 *len)
{ {