From 66d94ba4c0a9614f9560b337156f60fe9ea7aeeb Mon Sep 17 00:00:00 2001 From: Stephen Edworthy Date: Thu, 31 Mar 2022 09:09:32 +0100 Subject: [PATCH] mb/starlabs/laptop: Enable rtd3 for SSD on TGL Enabling rtd3 reduces power consumption when the SSD is idle. Tested and verified on the StarBook Mk V (TGL), using PowerTop on Manjaro 21.2.5 GNOME at 20% Brightness. Signed-off-by: Stephen Edworthy Change-Id: I0d8aa185a322bb8d1aba51ccaab03c521cec2770 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63254 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Sean Rhodes --- src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb index 66b8e86eb7..626425728d 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb @@ -182,6 +182,12 @@ chip soc/intel/tigerlake register "PcieClkSrcClkReq[3]" = "3" register "PcieRpSlotImplemented[8]" = "1" smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2/M 2280" "SlotDataBusWidth4X" + chip soc/intel/common/block/pcie/rtd3 + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D16)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" + register "srcclk_pin" = "3" + device generic 0 on end + end end device pci 1d.1 off end # PCI Express Port 10 device pci 1d.2 off end # PCI Express Port 11