GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard/google/kahlee: Add EC_IN_RW flag 

Depthcharge was complaining that the GPIO for this flag wasn't set.
The GPIO also needs to be an input, not an output.

BUG=b:67614692
TEST=Depthcharge no longer complains that there is no GPIO set for flag5.
The system boots again.

Change-Id: Ib854e97b0a3aa42a95ceb8a42a9776f0345ff8b1
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/21936
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
This commit is contained in:
Martin Roth 2017-10-10 10:34:48 -06:00
parent 0c8237aa0d
commit 6754e4ea20
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/kahlee/chromeos.c
View File

@ -22,6 +22,7 @@
/* SPI Write protect */ /* SPI Write protect */
#define CROS_WP_GPIO GPIO_142 #define CROS_WP_GPIO GPIO_142
#define GPIO_EC_IN_RW GPIO_15
void fill_lb_gpios(struct lb_gpios *gpios) void fill_lb_gpios(struct lb_gpios *gpios)
{ {
@ -30,6 +31,9 @@ void fill_lb_gpios(struct lb_gpios *gpios)
{-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"}, {-1, ACTIVE_HIGH, get_recovery_mode_switch(), "recovery"},
{-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, {-1, ACTIVE_HIGH, get_lid_switch(), "lid"},
{-1, ACTIVE_HIGH, 0, "power"}, {-1, ACTIVE_HIGH, 0, "power"},
{GPIO_EC_IN_RW, ACTIVE_HIGH, gpio_get(GPIO_EC_IN_RW),
"EC in RW"},
}; };
lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios));
} }

3
src/mainboard/google/kahlee/gpio.c
View File

@ -37,8 +37,7 @@ const GPIO_CONTROL oem_kahlee_gpio[] = {
| FCH_GPIO_OUTPUT_ENABLE}, | FCH_GPIO_OUTPUT_ENABLE},
/* EC_IN_RW */ /* EC_IN_RW */
{15, Function1, FCH_GPIO_PULL_UP_ENABLE | FCH_GPIO_OUTPUT_VALUE {15, Function1, FCH_GPIO_PULL_UP_ENABLE },
| FCH_GPIO_OUTPUT_ENABLE},
/* APU_I2C_3_SCL */ /* APU_I2C_3_SCL */
{19, Function1, FCH_GPIO_PULL_UP_ENABLE }, {19, Function1, FCH_GPIO_PULL_UP_ENABLE },