GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/autoport: Stop generate empty h8_mainboard_init_dock(). 

CB:36385 makes dock init in ramstage fully mainboard-specific, so
keeping generating empty h8_mainboard_init_dock() for lenovo EC becomes
unnecessary and problematic.

Change-Id: I19f57f41403ffd0319cc86f21bec7e142095df83
Signed-off-by: Bill XIE <persmule@hardenedlinux.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36752
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Bill XIE 2019-11-12 01:19:25 +08:00 committed by Patrick Georgi
parent 8088584b37
commit 675cb9152e
2 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
util/autoport/ec_lenovo.go
View File

@ -59,20 +59,6 @@ Method(_PTS,1)
si.WriteString("#include <drivers/pc80/pc/ps2_controller.asl>\n") si.WriteString("#include <drivers/pc80/pc/ps2_controller.asl>\n")
dock := Create(ctx, "dock.c")
defer dock.Close()
AddRAMStageFile("dock.c", "")
dock.WriteString(
`#include <ec/lenovo/h8/h8.h>
void h8_mainboard_init_dock (void)
{
/* FIXME: fill this if needed. */
}
`)
/* FIXME:XX Move this to ec/lenovo. */ /* FIXME:XX Move this to ec/lenovo. */
smi := Create(ctx, "smihandler.c") smi := Create(ctx, "smihandler.c")
defer smi.Close() defer smi.Close()

6
util/autoport/readme.md
View File

@ -407,9 +407,9 @@ Keep `GPE_EC_WAKE` and `GPE_EC_SCI` in sync with `gpi*_routing`.
`gpi*_routing` matching `GPE_EC_WAKE` or `GPE_EC_SCI` is set to `2` `gpi*_routing` matching `GPE_EC_WAKE` or `GPE_EC_SCI` is set to `2`
and all others are absent. and all others are absent.
If your dock has LPC wires or needs some special treatement you If your dock has LPC wires or needs some special treatement you may
need to fill `h8_mainboard_init_dock` and add support code to need to add codes to initialize the dock and support code to
DSDT. See the code for `x60`, `x200` or `x201` DSDT. See the `init_dock()` for `x60`, `x200` or `x201`.
## EC (generic laptop) ## EC (generic laptop)