From 6781648054cbabfe7642692fb080f908e95c31f3 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 17 Sep 2017 14:24:31 -0500 Subject: [PATCH] ec/quanta/it8518: correct ACPI battery data fed into ToString() ToString() requires the input buffer data to be null-terminated, but the data returned by the EC is not, leading Windows to fail to report any battery data at all. Correct this by concatenating a null terminator (0x00) to the end of the buffer data before inputting to ToString() where needed TEST: boot Windows on google/stout, observe battery data reported correctly. Change-Id: I974afcd6ff1c617301d0897d6bd1fe14200aa3b9 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/21579 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/ec/quanta/it8518/acpi/battery.asl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 1f37f130c9..862e907772 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -185,7 +185,7 @@ Device (BATX) // // Battery Type - Device Chemistry // - Store (ToString (SBCH), Index (PBIF, 11)) + Store (ToString (Concatenate(SBCH, 0x00)), Index (PBIF, 11)) // // Information ID 5 - @@ -196,7 +196,7 @@ Device (BATX) // // OEM Information - Manufacturer Name // - Store (ToString (SBMN), Index (PBIF, 12)) + Store (ToString (Concatenate(SBMN, 0x00)), Index (PBIF, 12)) // // Information ID 6 - @@ -207,7 +207,7 @@ Device (BATX) // // Model Number - Device Name // - Store (ToString (SBDN), Index (PBIF, 9)) + Store (ToString (Concatenate(SBDN, 0x00)), Index (PBIF, 9)) Return (PBIF) }