arch/x86: Don't allow hw floating point operations
Even though coreboot does not allow floating point operations some compilers like clang generate code using hw floating point registers, e.g. SSE %XMMx registers on 64bit code by default. Floating point operations need to be enabled in hardware for this to work (CR4). Also in SMM we explicitly need to save and restore floating point registers for this reason. If we instruct the compiler to not generate code with FPU ops, this simplifies our code as we can skip that step. With clang this reduces the binary size a bit. For instance ramstage for qemu/Q35 drops from 216600 bytes decompressed to 212768. TEST: See that with x86_64 bit and clang coreboot reaches the payload without setting the CR4_OSFXSR bit in CR4. Without this change it would bootloop very early in the bootblock on Qemu Q35. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Change-Id: Ib8590c55e7aed1ece2aa23b8ea99463396435e11 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75316 Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
7dab99856d
commit
67d9518586
|
@ -301,6 +301,10 @@ target-objcopy=-O elf64-x86-64 -B i386:x86-64
|
|||
LD_MACHINE =-m elf_x86_64
|
||||
endif
|
||||
|
||||
# Make sure generated code does not use XMMx and MMx registers
|
||||
CFLAGS_x86_32 += -mno-mmx -mno-sse
|
||||
CFLAGS_x86_64 += -mno-mmx -mno-sse
|
||||
|
||||
ramstage-srcs += $(wildcard src/mainboard/$(MAINBOARDDIR)/mainboard.c)
|
||||
ifeq ($(CONFIG_GENERATE_MP_TABLE),y)
|
||||
ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/mptable.c),)
|
||||
|
|
Loading…
Reference in New Issue