GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

google/storm: indicate start of normal boot on LED ring 

Instead of switching off the LED ring for the normal boot path, turn
it on with the dedicated pattern, indicating that the device firmware
has started executing.

BRANCH=storm
BUG=chrome-os-partner:39044
TEST=program the new firmware on an SP5 device and verify that the new
     'normal boot' pattern is displayed in all following scenarios:

 - power up the device (the pattern shows within the first second)

 - boot the device to bash prompt and restart.

 - press the recovery button and reboot the device. Once the LED ring
   shows the 'recovery button pressed' pattern, release the recovery
   button.

Change-Id: Iedd66d2575ad587af77e35d23efb22a83a92858b
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 092358bd17a323d0bd2fec555f43cb587486bbec
Original-Change-Id: I24de45326eab83b57bcf16b5598388f81c7d0f00
Original-Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/265536
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/9923
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Vadim Bendebury 2015-04-13 16:32:45 -07:00 committed by Patrick Georgi
parent ace3e3fc5e
commit 6897f4e796
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/storm/chromeos.c
View File

@ -106,6 +106,7 @@ static enum switch_state get_switch_state(void)
if (!sampled_value) { if (!sampled_value) {
saved_state = no_req; saved_state = no_req;
display_pattern(WWR_NORMAL_BOOT);
return saved_state; return saved_state;
} }
@ -139,7 +140,7 @@ static enum switch_state get_switch_state(void)
} }
} else { } else {
saved_state = no_req; saved_state = no_req;
display_pattern(WWR_ALL_OFF); display_pattern(WWR_NORMAL_BOOT);
} }
return saved_state; return saved_state;