From 6908e31ce689e3b6dbb5f698b07f41a708c53fbd Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Thu, 21 Jul 2022 14:11:59 -0700 Subject: [PATCH] Revert "mb/google/brya: Set EPP to 45% for all Brya variants" This reverts commit 938f33e9f7756d730a1da278679087476a476bf2. A power and performance analysis performed on Alder Lake demonstrated that with an EPP (Energy Performance Preference) at 50% along with EET (Energy Efficient Turbo) disabled, the overall SoC performance are similar or better and the SoC uses less power. For instance some browser benchmark results improved by 2% and some multi-core tests by 4% while at the same time power consumption lowered by approximately 7.6%. BRANCH=firmware-brya-14505.B BUG=b:240669428 TEST=verify that EPP is back to the by default 50% setting `iotools rdmsr 0 0x774' Signed-off-by: Jeremy Compostella Change-Id: Icacc555e62533ced30db83e0a036db1c85c0bfa6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/66283 Tested-by: build bot (Jenkins) Reviewed-by: Zhixing Ma Reviewed-by: Selma Bensaid Reviewed-by: Tim Wawrzynczak --- .../google/brya/variants/baseboard/brya/devicetree.cb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index b8349124ca..b6ede38cd9 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -122,10 +122,6 @@ chip soc/intel/alderlake }, }" - # set EPP to 45%: 45 * 256/100 = 115 = 0x73 - register "enable_energy_perf_pref" = "true" - register "energy_perf_pref_value" = "0x73" - device domain 0 on device ref igpu on end device ref dtt on end